feat: custom 404 response via headers #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nightnei
force-pushed
the
custom404Response
branch
from
a0f5db2
to
47c1c00
Compare
nightnei
force-pushed
the
custom404Response
branch
from
47c1c00
to
c3153e1
Compare
nightnei
force-pushed
the
custom404Response
branch
from
c4f98ac
to
f618320
Compare
StyleT
reviewed
Dec 16, 2021
src/app/index.ts
Outdated
|
|
||
| if (isCustomPage) { | ||
| status.headers = { | ||
| ['X-ILC-Override']: 'error-page-content', |
There was a problem hiding this comment.
I would expect to see this code with HTTP header in SSR code, rather then in AppSdk
Because before AppSdk knew nothing about server communication protocol
There was a problem hiding this comment.
I would say it's better to work this out through adapters that AppSdk receives at CSR & SSR respectively
nightnei
force-pushed
the
custom404Response
branch
from
fc92894
to
503ada9
Compare
nightnei
force-pushed
the
custom404Response
branch
from
503ada9
to
edefaba
Compare
nightnei
force-pushed
the
custom404Response
branch
4 times, most recently
from
9a9a076
to
ee2d4be
Compare
…equest function, and AppSdk is predefined in processRequest too
nightnei
force-pushed
the
custom404Response
branch
3 times, most recently
from
49c1781
to
fedbe93
Compare
nightnei
force-pushed
the
custom404Response
branch
from
fedbe93
to
5234643
Compare
nightnei
force-pushed
the
custom404Response
branch
from
8319638
to
588c5c4
Compare
StyleT
reviewed
Dec 17, 2021
| @@ -0,0 +1,4 @@ | |||
| export type TmpResponseData = { | |||
There was a problem hiding this comment.
Suggested change
| export type TmpResponseData = { | |
| export type SsrContext = { |
StyleT
approved these changes
Dec 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.