Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIXED] Connection type in scoped signing keys not honored #5789

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

kozlovic
Copy link
Member

The check of the allowed connection types must be maded after the user's permissions limits are possibly "swapped" with the scoped signer's.

Resolves #5786

Signed-off-by: Ivan Kozlovic ivan@synadia.com

The check of the allowed connection types must be maded after
the user's permissions limits are possibly "swapped" with the
scoped signer's.

Resolves #5786

Signed-off-by: Ivan Kozlovic <ivan@synadia.com>
@kozlovic kozlovic requested a review from a team as a code owner August 14, 2024 00:13
@kozlovic kozlovic requested a review from derekcollison August 14, 2024 00:14
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit c0c23c3 into main Aug 14, 2024
5 checks passed
@derekcollison derekcollison deleted the fix_5786 branch August 14, 2024 14:48
wallyqs added a commit that referenced this pull request Aug 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Connection type in scoped signing keys is not limited to MQTT
2 participants