Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NRG: empty snapshots dir if memory WAL #6169

Merged
merged 1 commit into from
Nov 25, 2024
Merged

NRG: empty snapshots dir if memory WAL #6169

merged 1 commit into from
Nov 25, 2024

Conversation

MauriceVanVeen
Copy link
Member

os.Remove(filepath.Join(n.sd, snapshotsDir, "*")) doesn't remove all files in the snapshots directory. This PR ensures the snapshots dir is cleaned up for in-memory WALs.

Signed-off-by: Maurice van Veen github@mauricevanveen.com

@MauriceVanVeen
NRG: empty snapshots dir if memory WAL
3edc0d1 
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
@MauriceVanVeen MauriceVanVeen requested a review from a team as a code owner November 25, 2024 09:47
@derekcollison derekcollison self-requested a review November 25, 2024 13:14
derekcollison
derekcollison approved these changes Nov 25, 2024
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

server/raft.go Show resolved Hide resolved
@derekcollison derekcollison merged commit 3ba828c into main Nov 25, 2024
5 checks passed
@derekcollison derekcollison deleted the maurice/memory-wal-empty-snapshots-dir branch November 25, 2024 13:15
@neilalexander neilalexander mentioned this pull request Nov 26, 2024
Merged
neilalexander added a commit that referenced this pull request Nov 26, 2024
@neilalexander
Cherry-picks for 2.10.23-RC.6 (#6181)
01635f1 
Includes the following:

- #6169
- #6165
- #6173
- #6175
- #6176
- #6178

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekcollison derekcollison derekcollison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MauriceVanVeen @derekcollison