Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry-picks for 2.10.23-RC.6 #6181

Merged
merged 10 commits into from
Nov 26, 2024
Merged

Cherry-picks for 2.10.23-RC.6 #6181

merged 10 commits into from
Nov 26, 2024

Conversation

Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
@neilalexander neilalexander requested a review from a team as a code owner November 26, 2024 17:12
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

go.mod Outdated Show resolved Hide resolved
go.mod Outdated Show resolved Hide resolved
@neilalexander
Copy link
Member Author

Have fixed the Go version bump in go.mod.

go.mod Outdated Show resolved Hide resolved
derekcollison and others added 9 commits November 26, 2024 17:24
…lize s2.Encode vs EncodeBetter wich is faster and compresses better on our meta snapshots.

Signed-off-by: Derek Collison <derek@nats.io>
…onsumer removals to avoind excesive snapshotting.

Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
…andle CRLFs correctly (#6175)

Leaf node credential parsing was using a regular expression that didn't
handle CRLFs correctly

Fix #6167

Signed-off-by: Your Name <alberto@synadia.com>

---------

Signed-off-by: Alberto Ricart <alberto@synadia.com>
Add in lookup for both stream and consumer assignments at the same time.

Signed-off-by: Derek Collison <derek@nats.io>
… or stream.

Processing a missing consumer was a heavier operation on the meta-layer and could lead to API queue buildup.
This processes that condition at point of entry to the system vs at the meta-layer. If the consumer assignment exists we do as normal for now.

Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Waldemar Quevedo <wally@nats.io>
Signed-off-by: Neil Twigg <neil@nats.io>
Copy link
Member

@wallyqs wallyqs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neilalexander neilalexander merged commit 01635f1 into release/v2.10.23 Nov 26, 2024
5 checks passed
@neilalexander neilalexander deleted the neil/21023rc6 branch November 26, 2024 18:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants