-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry-picks for 2.10.23-RC.6 #6181
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
derekcollison
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
wallyqs
reviewed
Nov 26, 2024
wallyqs
reviewed
Nov 26, 2024
neilalexander
force-pushed
the
neil/21023rc6
branch
from
November 26, 2024 17:19
3c795b5
to
f47c7c6
Compare
Have fixed the Go version bump in |
wallyqs
reviewed
Nov 26, 2024
…lize s2.Encode vs EncodeBetter wich is faster and compresses better on our meta snapshots. Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Derek Collison <derek@nats.io>
…onsumer removals to avoind excesive snapshotting. Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Maurice van Veen <github@mauricevanveen.com>
Add in lookup for both stream and consumer assignments at the same time. Signed-off-by: Derek Collison <derek@nats.io>
… or stream. Processing a missing consumer was a heavier operation on the meta-layer and could lead to API queue buildup. This processes that condition at point of entry to the system vs at the meta-layer. If the consumer assignment exists we do as normal for now. Signed-off-by: Derek Collison <derek@nats.io>
Signed-off-by: Waldemar Quevedo <wally@nats.io>
Signed-off-by: Neil Twigg <neil@nats.io>
neilalexander
force-pushed
the
neil/21023rc6
branch
from
November 26, 2024 17:24
f47c7c6
to
97a4010
Compare
wallyqs
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes the following:
Signed-off-by: Neil Twigg neil@nats.io