Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logging for large metalayer snapshots duration #6178

Merged
merged 2 commits into from
Nov 26, 2024
Merged

Add logging for large metalayer snapshots duration #6178

merged 2 commits into from
Nov 26, 2024
+18 −1

Conversation

wallyqs
Copy link
Member

@wallyqs wallyqs commented Nov 26, 2024

This adds extra WRN level logging to detect cases when there is a slowness in the metalayer snapshot duration, example line:

[WRN] Metalayer snapshot took 1.113s (streams: 326, consumers: 29382, marshal: 1.103s, uncompressed: 33268722, compressed: 2768064)

@wallyqs
Add logging for large metalayer snapshots duration
dff4fe8 
Signed-off-by: Waldemar Quevedo <wally@nats.io>
@wallyqs wallyqs requested a review from a team as a code owner November 26, 2024 15:02
@neilalexander
Improve granuality of meta snapshot measurements
bd5ee54 
Signed-off-by: Neil Twigg <neil@nats.io>
derekcollison
derekcollison approved these changes Nov 26, 2024
View reviewed changes
Copy link
Member

@derekcollison derekcollison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@derekcollison derekcollison merged commit 8b3bb06 into main Nov 26, 2024
5 checks passed
@derekcollison derekcollison deleted the meta-snapshot-took branch November 26, 2024 17:10
@neilalexander neilalexander mentioned this pull request Nov 26, 2024
Merged
neilalexander added a commit that referenced this pull request Nov 26, 2024
@neilalexander
Cherry-picks for 2.10.23-RC.6 (#6181)
01635f1 
Includes the following:

- #6169
- #6165
- #6173
- #6175
- #6176
- #6178

Signed-off-by: Neil Twigg <neil@nats.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@derekcollison derekcollison derekcollison approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wallyqs @derekcollison @neilalexander