fix(types): Fix the type declarations for the y tick format #2865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
thanks! |
github-actions bot
pushed a commit
that referenced
this pull request
Sep 23, 2022
# [3.6.0-next.2](3.6.0-next.1...3.6.0-next.2) (2022-09-23) ### Bug Fixes * **types:** Fix the type declarations for the y tick format ([#2865](#2865)) ([2e38dee](2e38dee)) ### Features * **api:** Enhance .config() to return generation options ([455944e](455944e)), closes [#2864](#2864) * **options:** Intent to ship bar.overlap ([046aedb](046aedb)), closes [#2839](#2839)
github-actions bot
pushed a commit
that referenced
this pull request
Sep 29, 2022
# [3.6.0](3.5.1...3.6.0) (2022-09-29) ### Bug Fixes * **area:** Fix unnecessary area element generation ([d43a1a7](d43a1a7)), closes [#2826](#2826) * **axis:** fix undefined error reading generatedTicks ([4f3c101](4f3c101)), closes [#2786](#2786) * **data:** Fix idConverter error ([98f7103](98f7103)), closes [#2808](#2808) * **gauge:** Fix size mismatch w/o gauge multi label text is hidden ([6ee8a1e](6ee8a1e)), closes [#2799](#2799) * **grid:** Remove grid.y.ticks default value ([4818e44](4818e44)), closes [#2809](#2809) * **legend:** Add default for legend.contents.template ([55fbb02](55fbb02)), closes [#2780](#2780) * **type:** Add missing polar module export ([a950abd](a950abd)), closes [#2833](#2833) * **typescript:** update entry point in tsconfig ([ab4d98d](ab4d98d)), closes [#2855](#2855) * **types:** Fix legend.item.tile.type literal type typo ([de9781f](de9781f)) * **types:** Fix the type declarations for the y tick format ([1d378e0](1d378e0)), closes [#2790](#2790) * **types:** Fix the type declarations for the y tick format ([#2865](#2865)) ([2e38dee](2e38dee)) ### Features * **api:** Enhance .config() to return generation options ([455944e](455944e)), closes [#2864](#2864) * **options:** Intent to ship bar.linearGradient ([3a9989f](3a9989f)), closes [#397](#397) * **options:** Intent to ship bar.overlap ([046aedb](046aedb)), closes [#2839](#2839) * **options:** Intent to ship data.groupsZeroAs ([3de8e7a](3de8e7a)), closes [#2813](#2813) * **options:** Intent to ship legend.item.tile.type ([c379c9f](c379c9f)), closes [#2874](#2874) * **packages:** Intent to ship React wrapper ([4cef6ad](4cef6ad)), closes [#2838](#2838)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue
this fixes the issue reported in fb246bc#r77903654
Details
This is resubmitting #2790 because you modified the patch when "merging" it in 1d378e0, which totally defeats the goal of the patch.
See #2676 for the original type checking error that this fixes (if the patch gets merged without reverting the most important part of it, the issue will finally be fixed)