Relax minimal patch version for serde_derive #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A conflict with cbindgen exists which prevent restson to be used with it. `cbindgen` [pins `serde_derive` to `1.0.58`](https://github.com/eqrion/cbindgen/blob/44e9b2112a06e46ddda6073e237d3a56df39c3e2/Cargo.toml#L24-L27) due to mozilla/cbindgen#203 so depending on `^1.0.80` prevents using both crates together. This patch simply relaxes the dependency on `serde_derive` to `1.0`, which is API compatible with both `1.0.80` and `1.0.58`. Closes spietika#14
This was referenced Jan 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A conflict with cbindgen exists which prevent restson to be used
with it.
cbindgenpinsserde_deriveto1.0.58due to mozilla/cbindgen#203
so depending on
^1.0.80prevents using both crates together.This patch simply relaxes the dependency on
serde_deriveto1.0,which is API compatible with both
1.0.80and1.0.58.Closes spietika#14