Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Relax minimal patch version for serde_derive #15

Merged
merged 1 commit into from
Jan 14, 2019

Conversation

nbigaouette-eai
Copy link
Contributor

A conflict with cbindgen exists which prevent restson to be used
with it. cbindgen pins serde_derive to 1.0.58
due to mozilla/cbindgen#203
so depending on ^1.0.80 prevents using both crates together.

This patch simply relaxes the dependency on serde_derive to 1.0,
which is API compatible with both 1.0.80 and 1.0.58.

Closes #14

Wrongly opened as nbigaouette-eai#1.

A conflict with cbindgen exists which prevent restson to be used
with it. `cbindgen` [pins `serde_derive` to `1.0.58`](https://github.com/eqrion/cbindgen/blob/44e9b2112a06e46ddda6073e237d3a56df39c3e2/Cargo.toml#L24-L27)
due to mozilla/cbindgen#203
so depending on `^1.0.80` prevents using both crates together.

This patch simply relaxes the dependency on `serde_derive` to `1.0`,
which is API compatible with both `1.0.80` and `1.0.58`.

Closes spietika#14
@spietika spietika merged commit 8e37fcc into spietika:master Jan 14, 2019
@nbigaouette-eai nbigaouette-eai deleted the 14-fix-serde-derive branch January 14, 2019 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants