Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compilation issue with serde_derive #14

Closed
nbigaouette-eai opened this issue Jan 13, 2019 · 2 comments
Closed

Compilation issue with serde_derive #14

nbigaouette-eai opened this issue Jan 13, 2019 · 2 comments
Assignees
@spietika

Comments

@nbigaouette-eai
Copy link
Contributor

I'd like to expose my client to Python so I'm trying to use milksnake to do so.

There seems to be a problem with cbindgen (used inside milksnake) which requires a fixed version of serde_derive (1.0.58).

But since restson explictly requires ^1.0.80, the combination of both cannot be used.

Could it be possible to relax the exact dependencies, at least for serde_derive? I think getting rid of the patch values should be enough:

hyper = "^0.12"
hyper-tls = "^0.3"
futures = "^0.1"
tokio-core = "^0.1"
serde = "^1.0"
serde_json = "^1.0"
serde_derive = "^1.0"
url = "^1.7"
log = "^0.4"
base64 = "^0.10"

letting cargo pick up the latest version. No need for a "required minimal patch version". And I believe this is the same as:

hyper = "0.12"
hyper-tls = "0.3"
futures = "0.1"
tokio-core = "0.1"
serde = "1.0"
serde_json = "1.0"
serde_derive = "1.0"
url = "1.7"
log = "0.4"
base64 = "0.10"
nbigaouette-eai added a commit to nbigaouette-eai/restson-rust that referenced this issue Jan 13, 2019
@nbigaouette-eai
Relax minimal patch version for serde_derive
1b83aa0 
A conflict with cbindgen exists which prevent restson to be used
with it. `cbindgen` [pins `serde_derive` to `1.0.58`](https://github.com/eqrion/cbindgen/blob/44e9b2112a06e46ddda6073e237d3a56df39c3e2/Cargo.toml#L24-L27)
due to mozilla/cbindgen#203
so depending on `^1.0.80` prevents using both crates together.

This patch simply relaxes the dependency on `serde_derive` to `1.0`,
which is API compatible with both `1.0.80` and `1.0.58`.

Closes spietika#14
@nbigaouette-eai nbigaouette-eai mentioned this issue Jan 13, 2019
Closed
@nbigaouette-eai
Copy link
Contributor Author

Hum... I screwed up and opened a PR to my own fork... 🤔
See nbigaouette-eai#1

@nbigaouette-eai nbigaouette-eai mentioned this issue Jan 14, 2019
Merged
@spietika spietika self-assigned this Jan 14, 2019
spietika pushed a commit that referenced this issue Jan 14, 2019
@nbigaouette-eai @spietika
Relax minimal patch version for serde_derive
8e37fcc 
A conflict with cbindgen exists which prevent restson to be used
with it. `cbindgen` [pins `serde_derive` to `1.0.58`](https://github.com/eqrion/cbindgen/blob/44e9b2112a06e46ddda6073e237d3a56df39c3e2/Cargo.toml#L24-L27)
due to mozilla/cbindgen#203
so depending on `^1.0.80` prevents using both crates together.

This patch simply relaxes the dependency on `serde_derive` to `1.0`,
which is API compatible with both `1.0.80` and `1.0.58`.

Closes #14
@spietika
Copy link
Owner

I also relaxed the version for serde and serde_json. Many other dependencies have not reached 1.0 yet, so I'll probably keep the minimum patch version just in case, unless similar problems arise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spietika spietika

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nbigaouette-eai @spietika