License, Readme and doc slight modifications #21
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@SimonRastikian could you also move the files in the current docs folder, to its own subfolder ecdsa (or even a subfolder under that) as it was done in the original PR? |
There was a problem hiding this comment.
Pull Request Overview
This pull request improves documentation and licensing for the threshold signatures repository. The changes focus on enhancing clarity and providing comprehensive information about the codebase's functionality and organization.
Key changes include:
- Complete rewrite of README.md with detailed technical documentation
- Addition of NEAR One Limited copyright to the LICENSE file
- Removal of outdated documentation files (key-generation.md and CHANGELOG.md)
Reviewed Changes
Copilot reviewed 4 out of 12 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| README.md | Complete rewrite providing comprehensive documentation of ECDSA/EdDSA implementations, functionalities, and technical details |
| LICENSE | Addition of NEAR One Limited copyright alongside existing copyright |
| docs/key-generation.md | Complete removal of outdated key generation protocol documentation |
| CHANGELOG.md | Complete removal of version history changelog |
kuksag
reviewed
Aug 1, 2025
gilcu3
requested changes
Aug 6, 2025
Contributor
gilcu3
left a comment
gilcu3
left a comment
There was a problem hiding this comment.
I just found a few minor issues. After they are fixed I am ready to approve
ghost
requested a review
from
gilcu3
approved these changes
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This task is inherited from the simon/passive-robust-ecdsa branch (PR #15) and tends to improve upon the documentation of the whole repo.
Linked to issue #5 and #19.
More should be done in this regard but so I set the PR as draft unless I am advised to keep it as it is.