Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[change] Remove backgroundClip prefix workaround #2254

Closed
wants to merge 1 commit into from
Closed

[change] Remove backgroundClip prefix workaround #2254

wants to merge 1 commit into from

Conversation

SukkaW
Copy link

@SukkaW SukkaW commented Mar 8, 2022

The PR removes the workaround for background-clip when prefixing.

The fix has been submitted to inline-style-prefixer as well, see robinweser/inline-style-prefixer#221

@SukkaW
Copy link
Author

SukkaW commented Mar 9, 2022

@necolas Should I change the target branch to 0.18-dev?

@SukkaW
Copy link
Author

SukkaW commented Mar 25, 2022

@necolas ping?

@necolas
Copy link
Owner

necolas commented Mar 25, 2022

The upstream package hasn't fixed the issue so there's nothing to here at the moment

@SukkaW
Copy link
Author

SukkaW commented Mar 26, 2022 •
edited
Loading

The upstream package hasn't fixed the issue so there's nothing to here at the moment

The fix I made here has more sense than the original workaround: it uses inline-style-prefixer's prefixMap feature.

An alternative will be to switch to https://github.com/thysultan/stylis

@necolas necolas added this to the 0.19: React 18 milestone Aug 28, 2022
@necolas necolas added the project:react-native-web Issue associated with react-native-web label Aug 28, 2022
@necolas necolas mentioned this pull request Oct 27, 2022
Merged
9 tasks
necolas
necolas reviewed Nov 2, 2022
View reviewed changes
packages/react-native-web/src/modules/prefixStyles/static.js
@@ -1,4 +1,3 @@
import backgroundClip from 'inline-style-prefixer/lib/plugins/backgroundClip';
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file is generated from ./scripts and shouldn't be manually altered

@necolas necolas removed this from the 0.19: React 18 milestone Nov 2, 2022
@SukkaW
Copy link
Author

SukkaW commented Nov 3, 2022

robinweser/inline-style-prefixer#221 has been merged by the upstream. Just wait for the upstream package bumping. In the meantime, I will close the PR (since it is quite outdated and has too many conflicts) and will open a new one.

@SukkaW SukkaW closed this Nov 3, 2022
@SukkaW SukkaW mentioned this pull request Nov 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@necolas necolas necolas left review comments

Assignees
No one assigned
Labels
project:react-native-web Issue associated with react-native-web
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SukkaW @necolas