[change] Remove backgroundClip prefix workaround #2427

SukkaW · 2022-11-16T11:14:16Z

The PR continues re-implement #2254 and now targets 0.19-dev.

robinweser/inline-style-prefixer#221 has been merged and released in 6.0.2, the PR bumps the version of inline-style-prefixer and removes the workaround for background-clip when prefixing.

* Support React 18 concurrency and constraints. * Add new render / hydrate functions. * Remove uses of findNodeHandle. * Expose ability to unmount an application once ran. Fix #1529 Close #2330

Encourage use of existing array syntax for multiple styles. Eventually we'll want to remove the compose() API to simplify the overall styling API.

And remove deprecated AppState.removeListener API Fix #2378

Previously deprecated, and not supported in the React Native Fabric architecture. Close #1935

Animated should now work with compiled and extracted styles. The original styles are passed to components, rather than being flattened into a new object that cannot be used by the style runtime to either lookup the results of StyleSheet.create calls or consume extracted styles. Inline styles that use AnimatedValue are moved into a seperate object that is appended to the original styles. Fix #2387

The resizeMode and tintColor props should be used instead. The styles will be removed in a future release. Fix #2383

Fix #1899 Close #1944

These components have been replaced by Pressable and will be removed from React Native. Fix #2382

codesandbox-ci · 2022-11-16T11:15:20Z

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit ed2ca6e:

Sandbox	Source
react-native-web-examples	Configuration

SukkaW · 2022-11-16T12:11:17Z

Blocked by robinweser/inline-style-prefixer#225

packages/react-native-web/src/modules/prefixStyles/static.js

azigler · 2022-11-16T17:49:03Z

@SukkaW The blocking PR was merged this morning, and now react-native-web isn't working unless the version is rolled back. Is this ready to merge?

robinweser · 2022-11-16T17:59:27Z

You can update to 7.0.0 to fix the issue here. Sorry for the inconvenience.

captDaylight · 2022-11-16T19:07:46Z

@SukkaW @azigler not ready until version bumped to 7.0.0 per @robinweser

dutradotdev · 2022-11-16T22:38:33Z

Hey @SukkaW
I am facing the issue Module not found: Error: Can't resolve 'inline-style-prefixer/lib/plugins/backgroundClip'
Is this issue related to your PR?

tks

SukkaW · 2022-11-17T02:41:14Z

You can update to 7.0.0 to fix the issue here. Sorry for the inconvenience.

@robinweser Looks like the fix should be released as 6.0.4, not 7.0.0 (otherwise the backport fix will not be applied to the existing react-native-web project).

robinweser · 2022-11-17T08:18:12Z

@SukkaW I released a 6.0.4 that fixes the error with a 7.0.0 that cleans it up.

rosen91 · 2023-07-02T06:50:13Z

@necolas I ran into this issue now, this fix was never published?
Using:
"name": "react-native-web",
"version": "0.19.6",

With Expo.

package-json still says "inline-style-prefixer": "^6.0.1"
I'm running it in a mono-repo if that has anything to say.

ERROR in ./node_modules/react-native-web/dist/modules/prefixStyles/static.js:1
Module not found: Can't resolve 'inline-style-prefixer/lib/plugins/backgroundClip'

1 | import backgroundClip from 'inline-style-prefixer/lib/plugins/backgroundClip';
2 | import crossFade from 'inline-style-prefixer/lib/plugins/crossFade';
3 | import cursor from 'inline-style-prefixer/lib/plugins/cursor';
4 | import filter from 'inline-style-prefixer/lib/plugins/filter';

necolas and others added 11 commits August 30, 2022 14:49

[change] Remove platform-specific exports

c8fe728

[change] React 18 support

a7e167a

* Support React 18 concurrency and constraints. * Add new render / hydrate functions. * Remove uses of findNodeHandle. * Expose ability to unmount an application once ran. Fix #1529 Close #2330

[change] StyleSheet.compose() deprecation

76225d6

Encourage use of existing array syntax for multiple styles. Eventually we'll want to remove the compose() API to simplify the overall styling API.

[change] Update Animated to support React 18

ff72921

And remove deprecated AppState.removeListener API Fix #2378

[change] Remove setNativeProps API

835232e

Previously deprecated, and not supported in the React Native Fabric architecture. Close #1935

[change] Image deprecate resizeMode and tintColor styles

45e965e

The resizeMode and tintColor props should be used instead. The styles will be removed in a future release. Fix #2383

[change] Map 'button' and 'paragraph' role to HTML elements

234a114

Fix #1899 Close #1944

[change] Deprecate Touchables and Button components

d87542b

These components have been replaced by Pressable and will be removed from React Native. Fix #2382

[chore] Bump inline-style-prefixer version

8da4c73

[change] Remove backgroundClip prefix workaround

086c466

SukkaW marked this pull request as draft November 16, 2022 11:21

SukkaW commented Nov 16, 2022

View reviewed changes

packages/react-native-web/src/modules/prefixStyles/static.js Show resolved Hide resolved

SukkaW added 2 commits November 16, 2022 23:09

[chore] Bump inline-style-prefixer version to 6.0.3

c0b06c0

[change] Re-generate prefixStyles/static.js

c5d7fa2

SukkaW marked this pull request as ready for review November 16, 2022 15:23

MkrierPharmanity mentioned this pull request Nov 16, 2022

web version wont start janaagaard75/expo-and-typescript#77

Open

azigler mentioned this pull request Nov 16, 2022

Can't resolve 'inline-style-prefixer/lib/plugins/backgroundClip robinweser/inline-style-prefixer#227

Closed

[chore] Bump inline-style-prefixer to 7.0.0

ed2ca6e

nephix mentioned this pull request Nov 18, 2022

Unable to resolve "inline-style-prefixer/lib/plugins/backgroundClip" #2431

Closed

1 task

necolas force-pushed the 0.19-dev branch from d87542b to e87074a Compare November 28, 2022 20:20

necolas force-pushed the 0.19-dev branch from e87074a to c26cb9b Compare December 27, 2022 16:04

necolas force-pushed the 0.19-dev branch from c26cb9b to 47671ca Compare March 20, 2023 19:26

necolas deleted the branch necolas:0.19-dev March 28, 2023 16:59

necolas closed this Mar 28, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[change] Remove backgroundClip prefix workaround #2427

[change] Remove backgroundClip prefix workaround #2427

SukkaW commented Nov 16, 2022

codesandbox-ci bot commented Nov 16, 2022 •

edited

Loading

SukkaW commented Nov 16, 2022

azigler commented Nov 16, 2022

robinweser commented Nov 16, 2022

captDaylight commented Nov 16, 2022

dutradotdev commented Nov 16, 2022

SukkaW commented Nov 17, 2022 •

edited

Loading

robinweser commented Nov 17, 2022

rosen91 commented Jul 2, 2023

[change] Remove backgroundClip prefix workaround #2427

[change] Remove backgroundClip prefix workaround #2427

Conversation

SukkaW commented Nov 16, 2022

codesandbox-ci bot commented Nov 16, 2022 • edited Loading

SukkaW commented Nov 16, 2022

azigler commented Nov 16, 2022

robinweser commented Nov 16, 2022

captDaylight commented Nov 16, 2022

dutradotdev commented Nov 16, 2022

SukkaW commented Nov 17, 2022 • edited Loading

robinweser commented Nov 17, 2022

rosen91 commented Jul 2, 2023

codesandbox-ci bot commented Nov 16, 2022 •

edited

Loading

SukkaW commented Nov 17, 2022 •

edited

Loading