New profile: lobster

[pirate486743186]

it's a shell script for streaming

[kmk3]

(Rebased to master to fix CI)

Just to confirm, is this https://github.com/justchokingaround/lobster?

[glitsj16]

Some checks needed for potential hardening.

[kmk3]

So this script is mostly a wrapper for mpv and yet the profile is more
restrictive than mpv.profile.

For example, it does not include paths which may be needed by mpv plugins:

include allow-lua.inc

whitelist /usr/share/lua
whitelist /usr/share/lua*

And it contains machine-id, which AFAIK may break pulseaudio.

Some of the extra restrictions make sense to me given the more focused
scenario, such as nodvd and include disable-xdg.inc.

How about keeping them and making this a redirect to mpv.profile?

To keep it in sync with mpv.profile and avoid duplication.

[pirate486743186]

(Rebased to master to fix CI)

Just to confirm, is this https://github.com/justchokingaround/lobster?

yes

[glitsj16]

Approved, just a few nits.

[pirate486743186]

@kmk3
It's a subjective choice.

The profile as is, is for simple use. It doesn't take into account plugins or weird pulseaudio configs.

@glitsj16 seams more interested in hardening it more.

[pirate486743186]

i also commented out machine-id for pulseaudio.

[glitsj16]

How about keeping them and making this a redirect to mpv.profile?
To keep it in sync with mpv.profile and avoid duplication.

That would indeed be a nicer way to do things, I agree.

[glitsj16]

LGTM on principal. Can you try @kmk3's suggestion to refactor this as mpv redirect?

[glitsj16]

Avoid including globals.local twice. Format to achieve that is in my comment.

[glitsj16]

LGTM. Nice to have this as a redirect profile now, congrats 👍.

[netblue30]

all in, thanks!