New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New profile: ani-cli #5707

Merged

netblue30 merged 1 commit into netblue30:master from pirate486743186:ani-cli

Mar 8, 2023

Contributor

pirate486743186 commented Mar 3, 2023

shell script for streaming anime

Collaborator

kmk3 commented Mar 3, 2023

(Rebased to master to fix CI)

Just to confirm, is this https://github.com/pystardust/ani-cli?

glitsj16 reviewed

View reviewed changes

etc/profile-a-l/ani-cli.profile Outdated Show resolved Hide resolved

glitsj16 reviewed

View reviewed changes

etc/profile-a-l/ani-cli.profile Outdated Show resolved Hide resolved

glitsj16 reviewed

View reviewed changes

etc/profile-a-l/ani-cli.profile Outdated Show resolved Hide resolved

glitsj16 reviewed

View reviewed changes

etc/profile-a-l/ani-cli.profile Outdated Show resolved Hide resolved

glitsj16 reviewed

View reviewed changes

etc/profile-a-l/ani-cli.profile Show resolved Hide resolved

glitsj16 requested changes

View reviewed changes

Collaborator

glitsj16 left a comment

Some checks needed for potential hardenings.

glitsj16 requested changes

View reviewed changes

Collaborator

glitsj16 left a comment

Some nits, but removing the noblacklist ${DOWNLOADS} is the main remark I have.

Contributor Author

pirate486743186 commented Mar 3, 2023

(Rebased to master to fix CI)

Just to confirm, is this https://github.com/pystardust/ani-cli?

yes

glitsj16 approved these changes

View reviewed changes

Collaborator

glitsj16 left a comment

LGTM

glitsj16 reviewed

View reviewed changes

etc/profile-a-l/ani-cli.profile Show resolved Hide resolved

glitsj16 requested changes

View reviewed changes

Collaborator

glitsj16 left a comment

Avoid including globals.local twice. Format to do that is included in my comment.

glitsj16 approved these changes

View reviewed changes

Collaborator

glitsj16 left a comment

LGTM. Thanks for the work!

rusty-snake reviewed

View reviewed changes

Collaborator

rusty-snake left a comment

I'm sceptical about the mpv redirect, otherwise LGTM.

etc/profile-a-l/ani-cli.profile Show resolved Hide resolved

etc/profile-a-l/ani-cli.profile Show resolved Hide resolved


          add ani-cli.profile

f1aa628

https://github.com/pystardust/ani-cli

Contributor Author

pirate486743186 commented Mar 7, 2023

Just merge them all. The new includes, don't even exist yet.

netblue30 merged commit 8476e2e into netblue30:master

Owner

netblue30 commented Mar 8, 2023

all in, thanks!

pirate486743186 deleted the ani-cli branch

March 8, 2023 17:36

kmk3 added a commit to kmk3/firejail that referenced this pull request


          mpv: move read-only entries to disable-common.inc

13cb318

Note: mpv itself does not modify anything in ~/.config/mpv as far as I
know, in which case it does not need a read-write entry.

Relates to netblue30#5706 netblue30#5707 netblue30#5710.

kmk3 mentioned this pull request

profiles: move read-only config entries to disable-common.inc #5763

Merged

kmk3 changed the title ~~add ani-cli.profile~~ New profile: ani-cli

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet