profiles: move read-only config entries to disable-common.inc #5763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are already present on etc/inc/disable-common.inc. First added on commit 695b67f ("handle ~/.config/user-dirs.dirs", 2015-11-17).
Note: mpv itself does not modify anything in ~/.config/mpv as far as I know, in which case it does not need a read-write entry. Relates to netblue30#5706 netblue30#5707 netblue30#5710.
rusty-snake
previously requested changes
Mar 28, 2023
Instead of duplicating them on every profile that tries to allow opening links in Firefox. And make that path read-write on firefox.profile.
This is an AUR helper and disable-common.inc has entries for pacman and other system package managers. Added on commit 6c10737 ("archaudit-report and cower for Arch platforms, netblue30#1642", 2017-11-15).
Command used to search for entries:
$ git grep '^read-only ${HOME}/' -- 'etc/profile*'
Note for gpg: ~/.gnupg/gpg.conf is apparently only managed by gpgconf(1)
rather than through gpg(1) itself, in which case it does not need to be
made read-write in gpg.profile.
kmk3
force-pushed
the
profiles-mv-readonly
branch
from
4085391 to
3a9b451
Compare
glitsj16
reviewed
Mar 28, 2023
glitsj16
approved these changes
Mar 28, 2023
kmk3
force-pushed
the
profiles-mv-readonly
branch
from
3a9b451 to
24f2a89
Compare
|
all merged! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should reduce duplication and increase hardening a bit.
Relates to #1642 #5635 #5706 #5707 #5710.
Cc: @pirate486743186 (from #5706 #5707 #5710)