Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] feat: postgres datastore implementation - part 2 #205

Draft
wants to merge 23 commits into
base: feat-netbox-assurance
Choose a base branch
from
Draft

[WIP] feat: postgres datastore implementation - part 2 #205

wants to merge 23 commits into from

Conversation

mfiedorowicz
Copy link
Member

No description provided.

mfiedorowicz and others added 17 commits December 4, 2024 12:14
@mfiedorowicz
feat: change postgres PK type
be2497c 
use INTEGER PRIMARY KEY GENERATED ALWAYS AS IDENTITY instead of SERIAL
ref: https://wiki.postgresql.org/wiki/Don%27t_Do_This#Don.27t_use_serial

Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
feat: reconciler - implement postgres.CreateIngestionLog
0199542 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
feat: change postgres char to varchar
da90760 
ref: https://wiki.postgresql.org/wiki/Don%27t_Do_This#Don.27t_use_char.28n.29
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
chore: SQL format
b469c38 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
Merge branch 'develop' into postgres-db-store-pt-2
6e174f6
@mfiedorowicz
feat: update postgres schemas and queries
013e630 
generate code with sqlc and mockery

Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
chore: regenerate mocks
ad4918c 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
feat: add branch ID to change set
8bcc199 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
feat: implement storage of ingestion logs and change sets in postgres…
413b6c2 
… database

Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
feat: retrieve ingestion logs from postgres
df235eb 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
chore: adjust unit tests
a72bdc4 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@dependabot @mfiedorowicz
chore(deps): bump golang.org/x/crypto in /diode-server (#200)
35b87cd 
Bumps [golang.org/x/crypto](https://github.com/golang/crypto) from 0.28.0 to 0.31.0.
- [Commits](golang/crypto@v0.28.0...v0.31.0)

---
updated-dependencies:
- dependency-name: golang.org/x/crypto
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
@ltucker @mfiedorowicz
chore: docker compose development overrides (#201)
19897cc
@ltucker @mfiedorowicz
feat: add branch support (#202)
57d9c37 
Co-authored-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@ltucker @mfiedorowicz
feat: ActionIngestionLog rpc (#203)
9a3b235
@ltucker @mfiedorowicz
chore: enable gofumpt lint (#204)
78d16a0
@mfiedorowicz
chore: gofumpt
e3012cc 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz mfiedorowicz self-assigned this Dec 17, 2024
@mfiedorowicz
chore: remove redis migrations
c12f1d1 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
chore: remove writing ingestion log to redis
c2048dc 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
fix: adjust unit tests
5269c76 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
Merge branch 'feat-netbox-assurance' into postgres-db-store-pt-2
7228a54 
# Conflicts:
#	diode-server/reconciler/ingestion_processor.go
#	diode-server/reconciler/logs_retriever.go
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 17, 2024 •
edited
Loading

Go test coverage

STATUS ELAPSED PACKAGE COVER PASS FAIL SKIP
🟢 PASS 0.00s github.com/netboxlabs/diode/diode-server/dbstore/postgres 0.0% 0 0 0
🟢 PASS 0.00s github.com/netboxlabs/diode/diode-server/gen/dbstore/postgres 0.0% 0 0 0
🟢 PASS 1.24s github.com/netboxlabs/diode/diode-server/ingester 71.2% 9 0 0
🟢 PASS 1.04s github.com/netboxlabs/diode/diode-server/migrator 68.2% 4 0 0
🟢 PASS 0.01s github.com/netboxlabs/diode/diode-server/netbox 0.0% 0 0 0
🟢 PASS 1.58s github.com/netboxlabs/diode/diode-server/netboxdiodeplugin 78.9% 42 0 0
🟢 PASS 1.44s github.com/netboxlabs/diode/diode-server/reconciler 83.9% 49 0 0
🟢 PASS 1.10s github.com/netboxlabs/diode/diode-server/reconciler/applier 88.9% 1 0 0
🟢 PASS 0.01s github.com/netboxlabs/diode/diode-server/reconciler/changeset 0.0% 0 0 0
🟢 PASS 1.33s github.com/netboxlabs/diode/diode-server/reconciler/differ 80.9% 81 0 0
🟢 PASS 1.02s github.com/netboxlabs/diode/diode-server/server 85.7% 14 0 0
🟢 PASS 1.01s github.com/netboxlabs/diode/diode-server/version 100.0% 1 0 0

Total coverage: 75.1%

@mfiedorowicz
chore: gofumpt
394698b 
Signed-off-by: Michal Fiedorowicz <mfiedorowicz@netboxlabs.com>
@mfiedorowicz
Merge branch 'feat-netbox-assurance' into postgres-db-store-pt-2
9303d33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@leoparente leoparente Awaiting requested review from leoparente leoparente will be requested when the pull request is marked ready for review leoparente is a code owner

@ltucker ltucker Awaiting requested review from ltucker ltucker will be requested when the pull request is marked ready for review ltucker is a code owner

Assignees

@mfiedorowicz mfiedorowicz

Labels
dependencies diode-ingester diode-proto diode-reconciler diode-server go internal
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mfiedorowicz @ltucker