Add default-param-last ESLint rule
#1419
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
added
the
type: chore
ehmicky
commented
Oct 16, 2020
src/commands/functions/create.js
Outdated
| @@ -356,7 +356,7 @@ async function createFunctionAddon({ api, addons, siteId, addonName, siteData, l | |||
| } | |||
| } | |||
|
|
|||
| async function installAddons(functionAddons = [], fnPath) { | |||
| async function installAddons(functionAddons, fnPath) { | |||
There was a problem hiding this comment.
functionAddons cannot be undefined here.
ehmicky
commented
Oct 16, 2020
| @@ -298,7 +298,7 @@ function initializeProxy(port, distDir, projectDir) { | |||
| return handlers | |||
| } | |||
|
|
|||
| async function startProxy(settings = {}, addonUrls, configPath, projectDir) { | |||
| async function startProxy(settings, addonUrls, configPath, projectDir) { | |||
There was a problem hiding this comment.
settings cannot be undefined here.
erezrokah
approved these changes
Oct 20, 2020
ehmicky
force-pushed
the
chore/lint-default-param-last
branch
2 times, most recently
from
5e17bcc to
088c2f5
Compare
ehmicky
force-pushed
the
chore/lint-default-param-last
branch
from
088c2f5 to
31d0dbb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the
default-param-lastESLint rule.