Remove forwarder name from discoverforwarder metadata #1204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ailable Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
denis-tingaikin
approved these changes
Dec 22, 2021
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Dec 22, 2021
…k@main PR link: networkservicemesh/sdk#1204 Commit: 371fbd8 Author: Artem Glazychev Date: 2021-12-22 15:01:29 +0700 Message: - Remove forwarder name from discoverforwarder metadata if it is not available (#1204) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Dec 22, 2021
…k@main PR link: networkservicemesh/sdk#1204 Commit: 371fbd8 Author: Artem Glazychev Date: 2021-12-22 15:01:29 +0700 Message: - Remove forwarder name from discoverforwarder metadata if it is not available (#1204) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Dec 22, 2021
…k@main PR link: networkservicemesh/sdk#1204 Commit: 371fbd8 Author: Artem Glazychev Date: 2021-12-22 15:01:29 +0700 Message: - Remove forwarder name from discoverforwarder metadata if it is not available (#1204) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Dec 22, 2021
…k@main PR link: networkservicemesh/sdk#1204 Commit: 371fbd8 Author: Artem Glazychev Date: 2021-12-22 15:01:29 +0700 Message: - Remove forwarder name from discoverforwarder metadata if it is not available (#1204) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Dec 22, 2021
…k@main PR link: networkservicemesh/sdk#1204 Commit: 371fbd8 Author: Artem Glazychev Date: 2021-12-22 15:01:29 +0700 Message: - Remove forwarder name from discoverforwarder metadata if it is not available (#1204) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Dec 22, 2021
…k@main PR link: networkservicemesh/sdk#1204 Commit: 371fbd8 Author: Artem Glazychev Date: 2021-12-22 15:01:29 +0700 Message: - Remove forwarder name from discoverforwarder metadata if it is not available (#1204) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
Dec 22, 2021
…k@main PR link: networkservicemesh/sdk#1204 Commit: 371fbd8 Author: Artem Glazychev Date: 2021-12-22 15:01:29 +0700 Message: - Remove forwarder name from discoverforwarder metadata if it is not available (#1204) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Dec 22, 2021
nsmbot
pushed a commit
to networkservicemesh/cmd-admission-webhook-k8s
that referenced
this pull request
Dec 22, 2021
…k@main PR link: networkservicemesh/sdk#1204 Commit: 371fbd8 Author: Artem Glazychev Date: 2021-12-22 15:01:29 +0700 Message: - Remove forwarder name from discoverforwarder metadata if it is not available (#1204) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Dec 22, 2021
…k@main PR link: networkservicemesh/sdk#1204 Commit: 371fbd8 Author: Artem Glazychev Date: 2021-12-22 15:01:29 +0700 Message: - Remove forwarder name from discoverforwarder metadata if it is not available (#1204) Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Dec 22, 2021
This was referenced Mar 23, 2023
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Artem Glazychev artem.glazychev@xored.com
Description
Remove forwarder name from discoverforwarder metadata if it is not available
For example, heal case :
nsc -> nsmgr1(restarted) -> fwd1 -> nsmgr2 -> fwd2(restarted) -> nseIf
nsmgr1dies,nsmgr2doesn't receiveClose()and continues to store oldfwd2name in metadataIssue link
#1196
How Has This Been Tested?
Types of changes