[PoC]: fix discover forwarder #1440
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
glazychev-art
force-pushed
the
fix_discoverforwarder
branch
2 times, most recently
from
647922a to
0418ec2
Compare
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1440 +/- ##
=======================================
Coverage ? 71.48%
=======================================
Files ? 235
Lines ? 10539
Branches ? 0
=======================================
Hits ? 7534
Misses ? 2535
Partials ? 470 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
Signed-off-by: Artem Glazychev <artem.glazychev@xored.com>
glazychev-art
force-pushed
the
fix_discoverforwarder
branch
from
0418ec2 to
613fd0f
Compare
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the forwarder is unavailable, we don't need to store its name.
But what do we need to do if the request returned an error?
Cases:
1. Forwarder is no longer available.
We need to clear the map with the forwarder name and find a new one on the re-request.
This solves the problem when several elements die - #1204
2. NSE is no longer available.
We can't just clear the map in this case. Because if
Closeis called next, we won't find anything in this map. But, the forwarder is fully reachable and contains interfaces.Therefore, in case of a Request error, we set the flag "active", that will allow us to select a new forwarder in case of a re-request. And correctly Close the connection if necessary.
Issue link
#1434
How Has This Been Tested?
Types of changes