fix: handle discover forwarder corner cases #1449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
denis-tingaikin
changed the title
denis-tingaikin
requested review from
glazychev-art,
d-uzlov and
NikitaSkrynnik
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## main #1449 +/- ##
=======================================
Coverage ? 70.25%
=======================================
Files ? 242
Lines ? 11012
Branches ? 0
=======================================
Hits ? 7736
Misses ? 2778
Partials ? 498 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
denis-tingaikin
force-pushed
the
fix-forwarder-selection
branch
from
2d02291 to
9e7ac0d
Compare
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
denis-tingaikin
force-pushed
the
fix-forwarder-selection
branch
from
3efd568 to
f2fd6d2
Compare
|
I think that with this PR we will see this problem again: |
|
@glazychev-art , @edwarnicke I think we might need to allow select a new forwarder if client wants re-select endpoint, because re-select criteria means Close (i.e. close datapath) See at . Thoughts? |
denis-tingaikin
force-pushed
the
fix-forwarder-selection
branch
from
3ec46db to
7023cbb
Compare
Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com>
denis-tingaikin
force-pushed
the
fix-forwarder-selection
branch
from
7023cbb to
1af8b99
Compare
edwarnicke
approved these changes
Apr 24, 2023
nsmbot
pushed a commit
to networkservicemesh/cmd-ipam-vl3
that referenced
this pull request
Apr 24, 2023
…k@main PR link: networkservicemesh/sdk#1449 Commit: d93d939 Author: Denis Tingaikin Date: 2023-04-24 18:16:54 +0300 Message: - fix: handle discover forwarder corner cases (#1449) * fix discover forwarder corner cases Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * self code review Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * allow choose a new forwarder if client wants reselect Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-map-ip-k8s
that referenced
this pull request
Apr 24, 2023
…k@main PR link: networkservicemesh/sdk#1449 Commit: d93d939 Author: Denis Tingaikin Date: 2023-04-24 18:16:54 +0300 Message: - fix: handle discover forwarder corner cases (#1449) * fix discover forwarder corner cases Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * self code review Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * allow choose a new forwarder if client wants reselect Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-admission-webhook-k8s
that referenced
this pull request
Apr 24, 2023
…k@main PR link: networkservicemesh/sdk#1449 Commit: d93d939 Author: Denis Tingaikin Date: 2023-04-24 18:16:54 +0300 Message: - fix: handle discover forwarder corner cases (#1449) * fix discover forwarder corner cases Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * self code review Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * allow choose a new forwarder if client wants reselect Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-memory
that referenced
this pull request
Apr 24, 2023
…k@main PR link: networkservicemesh/sdk#1449 Commit: d93d939 Author: Denis Tingaikin Date: 2023-04-24 18:16:54 +0300 Message: - fix: handle discover forwarder corner cases (#1449) * fix discover forwarder corner cases Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * self code review Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * allow choose a new forwarder if client wants reselect Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-cluster-info-k8s
that referenced
this pull request
Apr 24, 2023
…k@main PR link: networkservicemesh/sdk#1449 Commit: d93d939 Author: Denis Tingaikin Date: 2023-04-24 18:16:54 +0300 Message: - fix: handle discover forwarder corner cases (#1449) * fix discover forwarder corner cases Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * self code review Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * allow choose a new forwarder if client wants reselect Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-kernel
that referenced
this pull request
Apr 24, 2023
…k@main PR link: networkservicemesh/sdk#1449 Commit: d93d939 Author: Denis Tingaikin Date: 2023-04-24 18:16:54 +0300 Message: - fix: handle discover forwarder corner cases (#1449) * fix discover forwarder corner cases Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * self code review Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * allow choose a new forwarder if client wants reselect Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-registry-proxy-dns
that referenced
this pull request
Apr 24, 2023
…k@main PR link: networkservicemesh/sdk#1449 Commit: d93d939 Author: Denis Tingaikin Date: 2023-04-24 18:16:54 +0300 Message: - fix: handle discover forwarder corner cases (#1449) * fix discover forwarder corner cases Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * self code review Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * allow choose a new forwarder if client wants reselect Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-remote-vlan
that referenced
this pull request
Apr 24, 2023
…k@main PR link: networkservicemesh/sdk#1449 Commit: d93d939 Author: Denis Tingaikin Date: 2023-04-24 18:16:54 +0300 Message: - fix: handle discover forwarder corner cases (#1449) * fix discover forwarder corner cases Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * self code review Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * allow choose a new forwarder if client wants reselect Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsc-init
that referenced
this pull request
Apr 24, 2023
…k@main PR link: networkservicemesh/sdk#1449 Commit: d93d939 Author: Denis Tingaikin Date: 2023-04-24 18:16:54 +0300 Message: - fix: handle discover forwarder corner cases (#1449) * fix discover forwarder corner cases Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * self code review Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * allow choose a new forwarder if client wants reselect Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr-proxy
that referenced
this pull request
Apr 24, 2023
…k@main PR link: networkservicemesh/sdk#1449 Commit: d93d939 Author: Denis Tingaikin Date: 2023-04-24 18:16:54 +0300 Message: - fix: handle discover forwarder corner cases (#1449) * fix discover forwarder corner cases Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * self code review Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * allow choose a new forwarder if client wants reselect Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nse-vfio
that referenced
this pull request
Apr 24, 2023
…k@main PR link: networkservicemesh/sdk#1449 Commit: d93d939 Author: Denis Tingaikin Date: 2023-04-24 18:16:54 +0300 Message: - fix: handle discover forwarder corner cases (#1449) * fix discover forwarder corner cases Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * self code review Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * allow choose a new forwarder if client wants reselect Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/cmd-nsmgr
that referenced
this pull request
Apr 24, 2023
…k@main PR link: networkservicemesh/sdk#1449 Commit: d93d939 Author: Denis Tingaikin Date: 2023-04-24 18:16:54 +0300 Message: - fix: handle discover forwarder corner cases (#1449) * fix discover forwarder corner cases Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * self code review Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * allow choose a new forwarder if client wants reselect Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
nsmbot
pushed a commit
to networkservicemesh/sdk-k8s
that referenced
this pull request
Apr 24, 2023
…k@main PR link: networkservicemesh/sdk#1449 Commit: d93d939 Author: Denis Tingaikin Date: 2023-04-24 18:16:54 +0300 Message: - fix: handle discover forwarder corner cases (#1449) * fix discover forwarder corner cases Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * self code review Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> * allow choose a new forwarder if client wants reselect Signed-off-by: Denis Tingaikin <denis.tingajkin@xored.com> --------- Signed-off-by: NSMBot <nsmbot@networkservicmesh.io>
This was referenced Apr 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes #1434
Closes #1440
Closes #1448
Issue link
#1434
#1440
How Has This Been Tested?
Types of changes