Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Migrated @newrelic/koa into mainline agent repo #2148

Merged
merged 451 commits into from
Apr 17, 2024

Conversation

jsumners-nr
Copy link
Contributor

@jsumners-nr jsumners-nr commented Apr 16, 2024

This PR resolves #2126.

michaelgoin and others added 30 commits July 13, 2020 15:18
Adds additional dependency language to bottom of third party notices.
Co-authored-by: Michael Goin <michaelgoin@users.noreply.github.com>
…_updates

Updates to Readme, guidelines and templates
We are using fast-koa-router that set's _matchedRoute but does not set context.matched.
See https://github.com/nikostoulas/fast-koa-router/blob/master/src/router.ts#L12
Updating to latest newrelic library breaks our apps.
Check if transaction is null before accessing nameState property
Updated README as part of the repo consistency project
Copy link

codecov bot commented Apr 16, 2024

Codecov Report

Attention: Patch coverage is 94.58763% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 97.23%. Comparing base (38e47d9) to head (a338a21).

❗ Current head a338a21 differs from pull request most recent head 28d478b. Consider uploading reports for the commit 28d478b to get more accurate results

Files Patch % Lines
lib/instrumentation/koa/lib/instrumentation.js 90.50% 17 Missing ⚠️
.../instrumentation/koa/lib/router-instrumentation.js 96.63% 4 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2148      +/-   ##
==========================================
- Coverage   97.25%   97.23%   -0.02%     
==========================================
  Files         251      257       +6     
  Lines       42338    42725     +387     
==========================================
+ Hits        41175    41545     +370     
- Misses       1163     1180      +17     
Flag Coverage Δ
integration-tests-16.x 78.02% <24.74%> (-0.54%) ⬇️
integration-tests-18.x 78.00% <24.74%> (-0.53%) ⬇️
integration-tests-20.x 78.01% <24.74%> (-0.54%) ⬇️
unit-tests-16.x 89.88% <41.49%> (-0.47%) ⬇️
unit-tests-18.x 89.79% <41.49%> (-0.47%) ⬇️
unit-tests-20.x 89.79% <41.49%> (-0.47%) ⬇️
versioned-tests-16.x 75.07% <93.29%> (+0.28%) ⬆️
versioned-tests-18.x 76.16% <93.29%> (+0.27%) ⬆️
versioned-tests-20.x 76.16% <93.29%> (+0.27%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bizob2828 bizob2828 marked this pull request as ready for review April 17, 2024 19:35
@bizob2828 bizob2828 self-assigned this Apr 17, 2024
…s to lib/symbols, consolidated koa instrumentation into one folder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Migrate @newrelic/koa into repo