Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(done): Mark card as undone when updating card #5491

Merged
merged 1 commit into from
Jan 18, 2024
Merged

fix(done): Mark card as undone when updating card #5491

merged 1 commit into from
Jan 18, 2024

Conversation

stefan-niedermann
Copy link
Member

@stefan-niedermann stefan-niedermann commented Jan 18, 2024 •
edited
Loading

Summary

As stated in #534 (comment) updating the done property of a card via the REST API (without calling the /done and /undone endpoints explicitly) does only work "one way".

This commit allows setting null as new value thus allowing to mark cards as undone without an additional HTTP request but within a usual update request.

Refs: #534 #4137 c3b4ed6
CC: @desperateCoder @juliushaertl @TehThanos

Checklist

  • Code is properly formatted
  • Sign-off message is added to all commits
  • Tests (unit, integration, api and/or acceptance) are included
  • Documentation (manuals or wiki) has been updated or is not required

@stefan-niedermann
fix(done): Mark card as undone when updating card
cf4d626 
As stated in #534 (comment) updating the done property of a card via the REST API (without calling the /done and /undone endpoints explicitly) does only work "one way".

This commit allows setting null as new value thus allowing to mark cards as undone without an additional HTTP request but within a usual update request.

Refs: #534 #4137 c3b4ed6

Signed-off-by: Stefan Niedermann <info@niedermann.it>

Signed-off-by: Niedermann IT-Dienstleistungen <stefan-niedermann@users.noreply.github.com>
@stefan-niedermann stefan-niedermann mentioned this pull request Jan 18, 2024
Closed
@stefan-niedermann stefan-niedermann marked this pull request as ready for review January 18, 2024 11:22
@juliusknorr
Copy link
Member

Thanks a lot for the fix ❤️

@juliusknorr juliusknorr merged commit 488514c into main Jan 18, 2024
33 checks passed
@juliusknorr juliusknorr deleted the mark-as-undone-on-update branch January 18, 2024 11:36
@juliusknorr
Copy link
Member

/backport to stable28

@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Jan 18, 2024
Merged
stefan-niedermann added a commit to stefan-niedermann/nextcloud-deck that referenced this pull request Jan 18, 2024
@stefan-niedermann
feat(done): Limit write access to Done property to Deck server 1.12.2
55abed7 
Refs: #1556 nextcloud/deck#5491

Signed-off-by: Stefan Niedermann <info@niedermann.it>
@github-actions GitHub Actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliusknorr juliusknorr juliusknorr approved these changes

Assignees
No one assigned
Labels
3. to review bug feedback-requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Mark card as done
2 participants
@stefan-niedermann @juliusknorr