Mark card as done

[cloud2018]

Situation
Simple Board with stacks "to do", "doing" and "done" and due dates for cards. When a card is done in time the colour of the due date is grey and i move the card to the stack "done". After the due date the recalculated colour is red. There is no information, weather the card was done in time or over time, cause all my cards in stack "done" have a recalculated colour red of due date.

Describe the solution you'd like
I would like to see, that the card was done in time with no overdue.

It would be helpful, if i could stop the recalculation of the colour of a specific card, Perhaps an additional button like the "remove due date" button.

---

There is a $15 open bounty on this issue.

[juliusknorr]

That seems to be a pretty good idea. We should add an option to mark the card as finished in terms of the due date was made or not.

[delightfuldude]

@juliushaertl thanks for this great nextcloud app!
Any progress so far? Is there an option to mark cards as done/finished?

[Relax-Roger]

Has this (extremely useful) improvement ever been realised in the meantime?

[juliusknorr]

@Relax-Roger If it would have been implemented the issue would be closed. As you can see the issue is still labeled as "to develop" so no one has picked it up for development yet.

[Dubidubiduu]

My request is not the same as @cloud2018, but tied to that topic. I don't want reminders of finished tasks, so the label "finished" should have a technical meaning of not pushing a notification if the due date is over/near.

[alexanderdd]

@Dubidubiduu yes, that's what we need too. This way, the original due date stays on the card which is good for documentation.

Currently, I receive many notifications for tasks that are already done, the only way to stop notifications is to remove the due date.

[alexanderdd]

@cloud2018 (or @juliushaertl ?) I think the title of this issue should be renamed to "mark card 'done', & stop notifications".

Thinking about this issue, it's not easy to resolve. Most of the time, people will have a column "done". It is confusing to receive alerts for cards that I moved to "done".
In Zenkit, you can define a column as the "done" column, all cards dragged there get automatically marked as "done" and you don't receive "overdue" alerts any more.
In Asana, you can mark cards as "done", but it does not happen automatically when you drag them to your "done" column.

I would like to do some mockups for possible interfaces, but I need your opinions on:

1. Should it possible for all cards to be marked as "done" or only those with a due date?
2. Should cards automatically get marked as "done" when moved to the "done" column?
3. How and where should information be displayed about when a task was marked done, and if it was completed before or after the due date?

My thoughts:
for 1.: This is a big decision which might influence also views like #1319 I think all cards should be able to be marked as done.
for 2.: it sounds good at first sight, but I think my answer is 'no' because I cannot think of a good way to convey to the user that a certain column has this magic ability, or how to set this magic ability for a certain column. So it would be intransparent for the user.
for 3: An idea ("completed date" in sidebar view is filled automatically when a card is marked as "done")

[juliusknorr]

I think the title of this issue should be renamed to "mark card 'done', & stop notifications".

Yes, good point. Did that.

Should it possible for all cards to be marked as "done" or only those with a due date?
for 1.: This is a big decision which might influence also views like #1319 I think all cards should be able to be marked as done.

I agree, no need to limit that to cards with due dates.

Should cards automatically get marked as "done" when moved to the "done" column?
for 2.: it sounds good at first sight, but I think my answer is 'no' because I cannot think of a good way to convey to the user that a certain column has this magic ability, or how to set this magic ability for a certain column. So it would be intransparent for the user.

Yeah, at some point we should think about how we can make stacks related to different card states and how we can handle automatic card moving. Would you mind to open a separate issue for this?

How and where should information be displayed about when a task was marked done, and if it was completed before or after the due date?
for 3: An idea ("completed date" in sidebar view is filled automatically when a card is marked as "done")

I don't think we should have a manual date picker for the done option. A simple button to toggle the done state should be enough. But as the timestamp of setting the card to done is definitely useful, we should keep track of that.

[alexanderdd]

Now the [$15] is gone from the title.

So here are some concrete ideas for the interface.

(card state 1) all cards get a "mark as done" entry in the threedot menu (also cards without a due date).

(card state 2) If a card gets marked as done it looks like this. If the card had no due date, it just gets this green sticker. If it had a due date, it gets this green sticker and no notifications for this card are sent any more. If you click "Mark card as not done" the green sticker disappears. If it had a due date before, this due date is shown again.

(sidebar state 1) Sidebar gets a "mark as done" button at the top (and an "archive" button cause why not). Should look exactly like "new contact" button in the contacts app.

(sidebar state 2) When clicking "mark as done" button, this is shown.

This is actually revolutionary because we are introducing a new state for cards, before it had only archived/not archived and now it also has done/not done. I think in the future people also want to filter "show done cards" "hide done cards", like it is possible with archived cards.

Where can I find a Nextcloud styleguide? Like GNOME Human Interface Guidelines?

@juliushaertl I don't want to open the issue because I am not sure if it should be "cards automatically change properties when user moves them to certain column" or if it's "when user changes property of a card, automatically move card to certain column".

[cloud2018]

If there is a stack "done" and all cards marked with a green label there, i think this is very cluttering. A marker "done" in stack To Do is confusing, too.

I don't see a relevant difference between the last variant and a normal tag "done".

An improvement would be if you could see that a card was done in long before time, just in time or too late. to Archive this Just freeze the calculated color and text of the due date. In the example above "in one hour" and marked as yellow. Just my 2 cents.

[putt1ck]

I don't want to open the issue because I am not sure if it should be "cards automatically change properties when user moves them to certain column" or if it's "when user changes property of a card, automatically move card to certain column".
The problem with either is it presupposes the existence of a column for "done", which presupposes a single use case for boards. Maybe done should archive the card, if anything automatic should happen - which brings us back to done as a "don't nag about due date" or a checkbox added by the card creator.

[alexanderdd]

A different idea would be "turn off notifications" as proposed by @cloud2018

• In sidebar, behind due date field, have a checkbox "notifications" that is "on" by default. Switching it to "off" turns off due date notifications.
• In threedot menu on card, add an entry "turn off notifications".
• In notification, add button "turn off notifications for this card"
• if a card is archived, notifications are turned off (or is this already status quo?)

Clarifying questions:

1. Currently, are there any notifications apart from due date notifications?
2. Currently, all users of the board are notified about every card with due date, correct? Maybe think about "stop notifying me" "stop notifications for everyone"??

I actually like this idea better because there is no confusion about column "done" and attribute "done".

[alexanderdd]

Actually, I think the title of this issue should be "stop due date notifications for completed tasks [$15]". How this is achived (done button, checkmark next to due date etc) is still up for debate.
I feel "freeze color of due date label when card is completed" is a separate issue which can only be discussed once this issue here is solved.

By the way, also relevant: #566 and #1319

[juliusknorr]

Hey there,

I'd just like to let you know that due to the ongoing issue with Bountysource we're discussing ways to move to a different platform. As it looks right now, Bountysource might claim some of the money that was contributed by the community. We will try our best to prevent that. Historically we – the Nextcloud GmbH employees – simply put the claimed bounties back to other tickets until one was solved by a community member. So the money was always from the community and for the community. We'll therefore move to a better platform and currently don't post any new bounties until this situation is resolved. The current goal is to move/donate the money to Nextcloud include but details will follow in the forum post.

Hope this makes sense. If you have any questions please ask them on the forum. This comment will be copy-pasted to all open issues with bounties.

[alexanderdd]

can someone please rename this to "stop due date notifications for completed tasks"? I proposed this in my last comment, and nobody was against it, and it received two thumbs up.
Or, better: "stop due date notifications by marking card as 'done' "

Also, I still think my mock-ups above #534 (comment) are a good way to go, but I changed my mind a little bit: The "mark as done" button/menu item should be displayed only if a due date has been set.

[cloud2018]

The original issue was about the "colour of due date" and not about notifications, So I prefer to change the title back to "possibility to fix the colour of due date and stop recalculation" or "fix the colour of due date and stop recalculation by marking card as done" and open a separate issue "stop due date notifications by marking card as 'done' "

[juliusknorr]

can someone please rename this to "stop due date notifications for completed tasks"? I proposed this in my last comment, and nobody was against it, and it received two thumbs up.
Or, better: "stop due date notifications by marking card as 'done' "

The original issue was about the "colour of due date" and not about notifications, So I prefer to change the title back to "possibility to fix the colour of due date and stop recalculation" or "fix the colour of due date and stop recalculation by marking card as done" and open a separate issue "stop due date notifications by marking card as 'done' "

Those are both effects that marking a card as done would have, so I'd prefer to have the primary feature mentioned in the title. For implementation details, the whole thread should be revisited anyway.

[putt1ck]

Scoped labels sounds like something that could be done with Flow integration #1722

[dougti]

Well, looks like @TehThanos is finally doing something about this. Fingers crossed!

I started trying to use the Deck & Tasks apps on a daily basis recently, instead of using yet another 3rd-party site, however the lack of any way to mark a task as done made me think my Nextcloud was broken. I've spent the past 2 weeks looking for bug reports & potential conflicts. Having to archive cards to mark tasks as Done is completely counter-intuitive.

+1 fpr being able to associate Deck columns with Task statuses.

[dilomo]

I was feeling the same but in the last two years there were some guys that opposed progress at all costs so in the end I stopped using deck and now thinking of ditching nextcloud as well.

[britzke]

May be Tasks should be marked as finished with the Tasks-Application but if the Lists and Tasks of a Deck-Application Task are displayed there the checkbox for these tasks is disabled. May be this could be a cheap workaround (which is also not working now)

[chenasraf]

If at least we would be able to mark it as done from the tasks app... but not even that. Is there no workaround?

[Joedmin]

I'm also looking forward to this handy feature. The only way now is to delete the due date which is not as pleasant as just marking it as done

[nuokh]

Is there anything blocking this PR? Looks like all completed checks in #4137 passed.

[philipgierszal]

Hey guys,
any update on this PR? The date removal way is unfortunately not very satisfying as we are losing information on when the task was finished

[Nullcaller]

Yay! Can't wait for the update! And thanks so much for implementing this. It really puts the final cherry on top of the cake of productivity Nextcloud Deck was always meant to be.

[abelbabel]

Thank you for this feature!

I use Nextcloud 28.0.1.1 with Deck 1.12 and PHP 8.1 and cannot see the "Mark done"-option/-button ...

Did I miss something?

[desperateCoder]

@TehThanos @juliushaertl We're about to add this feature to the Android Deck app. We discovered, that we can set the done flag in the update-card endpoint (@PUT("v1.0/boards/{boardId}/stacks/{stackId}/cards/{cardId}")) and it works just fine. But somehow, if we send null (-> unmark as done), the done-flag won't be changed/resetted. If we just sync again afterwards, the server tells us that the card is still done with the same timestamp it had before.

Hint: I can't really tell if the SSO-lib/Files client is ignoring nulls (therefore omitting this field in json) or explicitly sending null. Would be great if both cases would be respected as "not-done"

I know about the /done and /undone endpoints, as I saw your UI using them, but for an app with offline-capabilities, this is quite inconvenient to use. We'd like the changes to be respected in the update-card endpoint as well, as it already does that (one-way, set-only).

Is there any chance we can get a small "bug"fix for this?

CC: @stefan-niedermann

[stefan-niedermann]

@desperateCoder issue addressed in #5491

[abelbabel]

Thank you for this feature!

I use Nextcloud 28.0.1.1 with Deck 1.12 and PHP 8.1 and cannot see the "Mark done"-option/-button ...

Did I miss something?

Strange thing is that I can mark cards as done with the deck-app for android, but at the same time I still don't see the option in the WebUI.

What's going on?

[SimJoSt]

After the update the button didn't appear in the web UI for me as well. I had clear my browser cache completely and reload, for it to show up.

[abelbabel]

Started over with a complete new profile in firefox (no cache or whatsoever) ... still no success ... User-Agent is Mozilla/5.0 (X11; Linux x86_64; rv:123.0) Gecko/20100101 Firefox/123.0 .

[SimJoSt]

Maybe you need to open a separate issue which can then be tracked as a bug, instead of appending to this feature request.