Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Mark card as done #1563

Merged
merged 28 commits into from
Jan 19, 2024
Merged

feat: Mark card as done #1563

merged 28 commits into from
Jan 19, 2024

Conversation

stefan-niedermann
Copy link
Owner

@stefan-niedermann stefan-niedermann commented Jan 13, 2024 •
edited
Loading

  • Display done information in favor of due date when present
  • Adjust colors to match latest Deck version
  • Change icon from 📆 to 🕙 for due dates
  • Use ✔️ icon when done is present in favor of 📆 / 🕙 in board view
  • Use ✔️ icon when done is present in favor of 📆 / 🕙 in single card widget
  • Add button to mark a card as done into the card view below the due date
  • Render done information if present in the card view
  • Make due date readonly when done information is present to align with the Deck server app
  • Limit UI for done state to Deck server app 1.12.0 or higher
  • Hide done cards from Upcoming view (See Deck server app issue)
  • Upsync undone does not work yet (See Deck server app issue)

Optional

  • Move temporal information into own reusable component to encapsulate logic
  • Move temporal information to bottom left of the card to align with Deck server app
  • Adjust styling and shape to align with Deck server app

desperateCoder and others added 2 commits December 22, 2023 13:24
@desperateCoder
#1556 mark card as done: first impl
2d62de8
@stefan-niedermann
feat(done): Display done state and adjust colors
7976b32 
Refs: #1556

Signed-off-by: Stefan Niedermann <info@niedermann.it>
@stefan-niedermann stefan-niedermann marked this pull request as draft January 13, 2024 12:29
@stefan-niedermann stefan-niedermann linked an issue Jan 13, 2024 that may be closed by this pull request
Implement new "mark as done" #1556
Closed
stefan-niedermann and others added 24 commits January 13, 2024 13:57
@stefan-niedermann
feat(done): Add button to mark a card as done into the card view belo…
8ab9514 
…w the due date

Refs: #1556

Signed-off-by: Stefan Niedermann <info@niedermann.it>
@stefan-niedermann
feat(done): Enhance due date / done UX in board view
8471bf3 
- Use ✔️ icon when done is present in favor of 📆 / 🕙 in board view
- Change icon from 📆 to 🕙 for due dates
- Move temporal information into own reusable component to encapsulate logic

Refs: #1556

Signed-off-by: Stefan Niedermann <info@niedermann.it>
@stefan-niedermann
feat(done): Use ✔️ icon when done is present in favor of 📆 / 🕙 in sin…
52ce22d 
…gle card widget

Refs: #1556

Signed-off-by: Stefan Niedermann <info@niedermann.it>
@stefan-niedermann
feat(done): Add "done" property to Card copy constructor
2694c8e 
Refs: #1556

Signed-off-by: Stefan Niedermann <info@niedermann.it>
@stefan-niedermann
feat(done): Enhance width of done button
a46f70e 
Refs: #1556

Signed-off-by: Stefan Niedermann <info@niedermann.it>
@desperateCoder
#1556 mark card as done: reset etags for update
515d1eb
@desperateCoder
#1556 mark card as done: reset etags for update
35f94be
@stefan-niedermann
feat(done): Show done state in card detail view
c970578 
Refs: #1556

Signed-off-by: Stefan Niedermann <info@niedermann.it>
@stefan-niedermann
feat(done): Align styling with Deck server app
5efb087 
Refs: #1556

Signed-off-by: Stefan Niedermann <info@niedermann.it>
@stefan-niedermann
chore(done): Limit done support to Deck server 1.12.0 and higher
8405834 
Refs: #1556

Signed-off-by: Stefan Niedermann <info@niedermann.it>
@stefan-niedermann
chore(done): Support compact mode
b8d1a2a 
Refs: #1556

Signed-off-by: Stefan Niedermann <info@niedermann.it>
@stefan-niedermann
chore(done): Adjust due date chip to match Deck server app
b66c01d 
- Make done icon circular
- Adjust logic to determine colors

Refs: #1556

Signed-off-by: Stefan Niedermann <info@niedermann.it>
@stefan-niedermann
chore(done): Use filled checkbox item for tasks
47145c1 
Signed-off-by: Stefan Niedermann <info@niedermann.it>
@stefan-niedermann
chore(done): Use onSurfaceVariant for future due dates
976308d 
Signed-off-by: Stefan Niedermann <info@niedermann.it>
@stefan-niedermann
chore(done): Remove unused resources
b5dd1df 
Signed-off-by: Stefan Niedermann <info@niedermann.it>
@desperateCoder
#1556 mark card as done: hide done cards in upcoming-cards view
65cde2b
@stefan-niedermann
feat(done): Also filter cards which are done at timestamp 0 for Upcom…
3b5301c 
…ing cards

Safety first.

Refs: #1556

Signed-off-by: Stefan Niedermann <info@niedermann.it>
@stefan-niedermann
feat(done): Limit write access to Done property to Deck server 1.12.2
55abed7 
Refs: #1556 nextcloud/deck#5491

Signed-off-by: Stefan Niedermann <info@niedermann.it>
@stefan-niedermann
feat(done): Allow filtering for (un)done cards
eea21c7 
Refs: #1556 nextcloud/deck#5406

Signed-off-by: Stefan Niedermann <info@niedermann.it>
@stefan-niedermann
feat(filter): Use "reset" in favor of "clear" for resetting filters
a20a2de 
Signed-off-by: Stefan Niedermann <info@niedermann.it>
@stefan-niedermann
chore: Use class names instead of magic string literals in exceptions
598d87f 
Signed-off-by: Stefan Niedermann <info@niedermann.it>
@stefan-niedermann
fix(done): Fix crash when filtering for both, done and due date at th…
152bc59 
…e same time

Signed-off-by: Stefan Niedermann <info@niedermann.it>
@stefan-niedermann
chore(deps): Do no longer rely on android-commons lib to calculate dp…
1d18d0b 
… to px

Signed-off-by: Stefan Niedermann <info@niedermann.it>
@stefan-niedermann
feat(done): Change wording of undone to "Not completed" to match Deck…
6fc89e3 
… server

Refs: #1556

Signed-off-by: Stefan Niedermann <info@niedermann.it>
@stefan-niedermann stefan-niedermann changed the title Mark card as done feat: Mark card as done Jan 19, 2024
@stefan-niedermann
fix(done): Show clearDone button only when done is supported
7c8bc68 
Refs: #1556

Signed-off-by: Stefan Niedermann <info@niedermann.it>
@stefan-niedermann stefan-niedermann marked this pull request as ready for review January 19, 2024 20:36
@stefan-niedermann stefan-niedermann merged commit 3ae2636 into master Jan 19, 2024
10 checks passed
@stefan-niedermann stefan-niedermann deleted the mark-card-as-done branch January 19, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement new "mark as done"
2 participants
@stefan-niedermann @desperateCoder