Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement new "mark as done" #1556

Closed
pschopen opened this issue Dec 21, 2023 · 7 comments · Fixed by #1563
Closed

Implement new "mark as done" #1556

pschopen opened this issue Dec 21, 2023 · 7 comments · Fixed by #1563
Labels
enhancement New feature or request

Comments

@pschopen
Copy link

In the web version (1.12.0) now cards can be marked as done. Would be good if the android app had that, too.
@pschopen pschopen added the enhancement New feature or request label Dec 21, 2023
desperateCoder added a commit that referenced this issue Dec 22, 2023
@desperateCoder
#1556 mark card as done: first impl
2d62de8
stefan-niedermann added a commit that referenced this issue Jan 13, 2024
@stefan-niedermann
feat(done): Display done state and adjust colors
7976b32 
Refs: #1556

Signed-off-by: Stefan Niedermann <info@niedermann.it>
@stefan-niedermann stefan-niedermann linked a pull request Jan 13, 2024 that will close this issue
feat: Mark card as done #1563
Merged
14 tasks
stefan-niedermann added a commit that referenced this issue Jan 13, 2024
@stefan-niedermann
feat(done): Add button to mark a card as done into the card view belo…
8ab9514 
…w the due date

Refs: #1556

Signed-off-by: Stefan Niedermann <info@niedermann.it>
stefan-niedermann added a commit that referenced this issue Jan 14, 2024
@stefan-niedermann
feat(done): Enhance due date / done UX in board view
8471bf3 
- Use ✔️ icon when done is present in favor of 📆 / 🕙 in board view
- Change icon from 📆 to 🕙 for due dates
- Move temporal information into own reusable component to encapsulate logic

Refs: #1556

Signed-off-by: Stefan Niedermann <info@niedermann.it>
stefan-niedermann added a commit that referenced this issue Jan 14, 2024
@stefan-niedermann
feat(done): Use ✔️ icon when done is present in favor of 📆 / 🕙 in sin…
52ce22d 
…gle card widget

Refs: #1556

Signed-off-by: Stefan Niedermann <info@niedermann.it>
@stefan-niedermann stefan-niedermann pinned this issue Jan 14, 2024
stefan-niedermann added a commit that referenced this issue Jan 14, 2024
@stefan-niedermann
feat(done): Add "done" property to Card copy constructor
2694c8e 
Refs: #1556

Signed-off-by: Stefan Niedermann <info@niedermann.it>
stefan-niedermann added a commit that referenced this issue Jan 14, 2024
@stefan-niedermann
feat(done): Enhance width of done button
a46f70e 
Refs: #1556

Signed-off-by: Stefan Niedermann <info@niedermann.it>
desperateCoder added a commit that referenced this issue Jan 15, 2024
@desperateCoder
#1556 mark card as done: reset etags for update
515d1eb
desperateCoder added a commit that referenced this issue Jan 15, 2024
@desperateCoder
#1556 mark card as done: reset etags for update
35f94be
stefan-niedermann added a commit that referenced this issue Jan 15, 2024
@stefan-niedermann
feat(done): Show done state in card detail view
c970578 
Refs: #1556

Signed-off-by: Stefan Niedermann <info@niedermann.it>
stefan-niedermann added a commit that referenced this issue Jan 15, 2024
@stefan-niedermann
feat(done): Align styling with Deck server app
5efb087 
Refs: #1556

Signed-off-by: Stefan Niedermann <info@niedermann.it>
stefan-niedermann added a commit that referenced this issue Jan 15, 2024
@stefan-niedermann
chore(done): Limit done support to Deck server 1.12.0 and higher
8405834 
Refs: #1556

Signed-off-by: Stefan Niedermann <info@niedermann.it>
stefan-niedermann added a commit that referenced this issue Jan 16, 2024
@stefan-niedermann
chore(done): Support compact mode
b8d1a2a 
Refs: #1556

Signed-off-by: Stefan Niedermann <info@niedermann.it>
stefan-niedermann added a commit that referenced this issue Jan 16, 2024
@stefan-niedermann
chore(done): Adjust due date chip to match Deck server app
b66c01d 
- Make done icon circular
- Adjust logic to determine colors

Refs: #1556

Signed-off-by: Stefan Niedermann <info@niedermann.it>
desperateCoder added a commit that referenced this issue Jan 16, 2024
@desperateCoder
#1556 mark card as done: hide done cards in upcoming-cards view
65cde2b
stefan-niedermann added a commit that referenced this issue Jan 16, 2024
@stefan-niedermann
feat(done): Also filter cards which are done at timestamp 0 for Upcom…
3b5301c 
…ing cards

Safety first.

Refs: #1556

Signed-off-by: Stefan Niedermann <info@niedermann.it>
stefan-niedermann added a commit that referenced this issue Jan 18, 2024
@stefan-niedermann
feat(done): Limit write access to Done property to Deck server 1.12.2
55abed7 
Refs: #1556 nextcloud/deck#5491

Signed-off-by: Stefan Niedermann <info@niedermann.it>
stefan-niedermann added a commit that referenced this issue Jan 18, 2024
@stefan-niedermann
feat(done): Allow filtering for (un)done cards
eea21c7 
Refs: #1556 nextcloud/deck#5406

Signed-off-by: Stefan Niedermann <info@niedermann.it>
stefan-niedermann added a commit that referenced this issue Jan 18, 2024
@stefan-niedermann
feat(done): Change wording of undone to "Not completed" to match Deck…
6fc89e3 
… server

Refs: #1556

Signed-off-by: Stefan Niedermann <info@niedermann.it>
stefan-niedermann added a commit that referenced this issue Jan 19, 2024
@stefan-niedermann
fix(done): Show clearDone button only when done is supported
7c8bc68 
Refs: #1556

Signed-off-by: Stefan Niedermann <info@niedermann.it>
stefan-niedermann added a commit that referenced this issue Jan 20, 2024
@stefan-niedermann
chore(deps): Update nextcloud-commons to 1.9.0
740836b 
Refs: #1556

Signed-off-by: Stefan Niedermann <info@niedermann.it>
stefan-niedermann added a commit that referenced this issue Jan 20, 2024
@stefan-niedermann
fix: Fix finalResId issues
a610e08 
Refs: #1556

Signed-off-by: Stefan Niedermann <info@niedermann.it>
@stefan-niedermann
Copy link
Owner

Will be published with Deck Android 1.24.0

@gnilebein gnilebein mentioned this issue Feb 7, 2024
Closed
@rogercreagh
Copy link

Err - I'm using v1.24.1 but I can't find any way to mark a card as Done. Where is it hidden?

@stefan-niedermann
Copy link
Owner

Screenshot_20240904-125355_Nextcloud Deck

The big fat purple button was too obvious, wasn't it? 😆

@rogercreagh
Copy link

I'm sure it would be blindingly obvious if it wasn't invisible 8-(
image

@stefan-niedermann
Copy link
Owner

Well, in this case: Which version exactly are you using on Deck Android and on Deck server?

@rogercreagh
Copy link

Ah, maybe that's the problem - android app version 1.24.1 and NC Deck app 1.8.8 - but it says that version is up to date.

I see that the OP in this thread refers to web version 1.12.0 but that doesn't appear to exist on my system and it reports 1.8.8 as being the current version.

I wonder how I'm supposed to update it (and whether any other apps are also missing updates)

NC server version is 25.0.13 - I wonder if that is the problem. I seldom visit the NC server interface (if it ain't broke don't fix it) as I never use it - NC is just a file and data store for me and I can do without all the online apps. I guess I'll do some maintenance and see if that enablles the Done facility.

Sorry for wasting your time, and thanks for the prompt.

@stefan-niedermann
Copy link
Owner

No problem, but as you guessed yourself: The server has to support it (and Deck Android recognizes this feature and en/disables it accordingly on Android)

@stefan-niedermann stefan-niedermann unpinned this issue Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Mark card as done stefan-niedermann/nextcloud-deck
3 participants
@stefan-niedermann @rogercreagh @pschopen