Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sharing icon not displayed for files shared to the user #38156

Closed
Clementine46 opened this issue May 9, 2023 · 9 comments · Fixed by #40517
Closed

Sharing icon not displayed for files shared to the user #38156

Clementine46 opened this issue May 9, 2023 · 9 comments · Fixed by #40517
Labels

Comments

@Clementine46
Copy link

Most files on Nextcloud have a sharing icon on the right, next to the file's menu.

However, when another user shares a file with me, the sharing icon is replaced by the avatar of said user. This change can be quite confusing for some users, as they won't know where to click if they want to open the sharing panel on the right.

Artboard Copy 10

I conducted a series of user tests, in which practically all users, even the advanced ones, hesitated when asked to share a folder that had been shared to them. Some of them also bypassed the issue by going into the details, inside the file's menu.

The lack of sharing icon is confusing for users. I suggest to make it permanent to make things more cohesive and easier to understand. The icon also doesn't take a lot of space.

Artboard Copy 6

@jancborchardt @nimishavijay what do you think ? :)

@Clementine46 Clementine46 added enhancement design Design, UI, UX, etc. 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels May 9, 2023
@szaimen szaimen moved this to 🧭 Planning evaluation / ideas in 🖍 Design team May 12, 2023
@szaimen szaimen self-assigned this Jul 17, 2023
@szaimen
Copy link
Contributor

szaimen commented Jul 19, 2023

In my opinion the mockup looks good. So reaching over to engineering. cc @nextcloud/server-frontend

@szaimen szaimen moved this from 🧭 Planning evaluation / ideas to 🏗️ At engineering in 🖍 Design team Jul 19, 2023
@szaimen szaimen added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Jul 19, 2023
@nimishavijay
Copy link
Member

Mockup by @Clementine46 looks good to me!

Additionally on mobile, since there is a lack of space, I suggest that we show a Share action in the action menu of a file/folder as the third item, after Details.

Similarly in the menu for the clients as well we could show a Share action as well, cc @tobiasKaminsky

@jancborchardt jancborchardt moved this from 🏗️ At engineering to 🧭 Planning evaluation / ideas in 🖍 Design team Aug 15, 2023
@artonge artonge mentioned this issue Aug 18, 2023
26 tasks
@skjnldsv
Copy link
Member

skjnldsv commented Sep 2, 2023

From #37208

Two issues with the "Shared" indicator in the files list

  • It is not super present
  • The icons are not aligned with the icons of non-shared files

Describe the solution you'd like

  • The text and icon of the "Shared" indicator could be colorized in var(--color-primary-element)
  • The icons would look better if to the right of the "Shared" text, so they align with the other icons in the list

Additional context

Current:
image

Proposed:
Sharing colorized

I guess we could have both

@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 1. to develop Accepted and waiting to be taken care of labels Sep 19, 2023
@skjnldsv skjnldsv self-assigned this Sep 19, 2023
@skjnldsv
Copy link
Member

@Clementine46 and @nextcloud/designers
Since we now have real button-like design int he files app (for accessibility and from the API), can you do me a feedback on this please:
image

@szaimen
Copy link
Contributor

szaimen commented Sep 20, 2023

Looks very good to me now that the status looks like a button that can be clicked :)

@Jerome-Herbinet
Copy link
Member

I love it !

@github-project-automation github-project-automation bot moved this from 🧭 Planning evaluation / ideas to 🎉 Done in 🖍 Design team Sep 20, 2023
@szaimen
Copy link
Contributor

szaimen commented Nov 22, 2023

Reopening due to #41656

@szaimen szaimen reopened this Nov 22, 2023
@szaimen szaimen added 1. to develop Accepted and waiting to be taken care of and removed 3. to review Waiting for reviews labels Nov 22, 2023
@szaimen szaimen moved this from 🎉 Done to 📐 Design phase in 🖍 Design team Nov 22, 2023
@skjnldsv
Copy link
Member

skjnldsv commented Feb 7, 2024

@jancborchardt Jan C. Borchardt removed this from 🖍 Design team 3 weeks ago

So we don't want this?

@skjnldsv
Copy link
Member

skjnldsv commented Feb 8, 2024

Closing see #43443

@skjnldsv skjnldsv closed this as completed Feb 8, 2024
@skjnldsv skjnldsv closed this as not planned Won't fix, can't repro, duplicate, stale Feb 8, 2024
@skjnldsv skjnldsv removed the 1. to develop Accepted and waiting to be taken care of label Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants