Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show shared label only if the current user have shared the file. #41656

Conversation

marcoambrosini
Copy link
Member

@marcoambrosini marcoambrosini commented Nov 22, 2023

The presence of the text "Sharing label" in all shared files caused the view to be too loaded, so it's been decided to show it only when the current user is the owner of the share.

Summary

Screenshot from 2023-11-22 15-42-42

TODO

  • ...

Checklist

@marcoambrosini marcoambrosini self-assigned this Nov 22, 2023
@marcoambrosini marcoambrosini requested review from a team, szaimen and emoral435 and removed request for a team November 22, 2023 08:03
Copy link
Member

@jancborchardt jancborchardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, as this is just the previous state with the slight color improvement and switch of icon/text, without any further modification. @karlitschek for review as well since you reported it.

Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will basically re-introduce #38156. So not sure if I agree with this change.

@jancborchardt
Copy link
Member

@szaimen see @marcoambrosini’s comment at #41620 (comment) – it’s either this or the full-blown "Shared" label everywhere which @karlitschek also reported as being too present.

So for now I think it’s better if we go back to a slightly improved version of the original state.

@AndyScherzinger AndyScherzinger added this to the Nextcloud 28 milestone Nov 22, 2023
@szaimen
Copy link
Contributor

szaimen commented Nov 22, 2023

@szaimen see @marcoambrosini’s comment at #41620 (comment) – it’s either this or the full-blown "Shared" label everywhere which @karlitschek also reported as being too present.

yes, I saw that but still do not like this change. Anyway, feel free to approve the PR yourself. I am not blocking it. :)

This was referenced Nov 22, 2023
@AndyScherzinger AndyScherzinger force-pushed the enh/41620/shared-label-takes-a-lot-of-space-in-files-list branch from 89a339d to 710d4a2 Compare November 22, 2023 15:38
@AndyScherzinger
Copy link
Member

/compile amend /

The presence of the text "Sharing label" in all shared files caused
the view to be too loaded, so it's been decided to show it only when
the current user is the owner of the share.

Signed-off-by: Marco Ambrosini <marcoambrosini@proton.me>
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@nextcloud-command nextcloud-command force-pushed the enh/41620/shared-label-takes-a-lot-of-space-in-files-list branch from 710d4a2 to fc36367 Compare November 22, 2023 15:41
@AndyScherzinger AndyScherzinger merged commit 0309faa into master Nov 22, 2023
40 checks passed
@AndyScherzinger AndyScherzinger deleted the enh/41620/shared-label-takes-a-lot-of-space-in-files-list branch November 22, 2023 16:19
@marcoambrosini
Copy link
Member Author

For what is worth, I also think it's better to always show the shared label at all times. I think it's the 2nd most important thing after the file name. Let's figure out a better strategy to make things clear soon!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Shared" label takes a lot of space in Files list
4 participants