-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show shared label only if the current user have shared the file. #41656
Show shared label only if the current user have shared the file. #41656
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, as this is just the previous state with the slight color improvement and switch of icon/text, without any further modification. @karlitschek for review as well since you reported it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This will basically re-introduce #38156. So not sure if I agree with this change.
@szaimen see @marcoambrosini’s comment at #41620 (comment) – it’s either this or the full-blown "Shared" label everywhere which @karlitschek also reported as being too present. So for now I think it’s better if we go back to a slightly improved version of the original state. |
yes, I saw that but still do not like this change. Anyway, feel free to approve the PR yourself. I am not blocking it. :) |
89a339d
to
710d4a2
Compare
/compile amend / |
The presence of the text "Sharing label" in all shared files caused the view to be too loaded, so it's been decided to show it only when the current user is the owner of the share. Signed-off-by: Marco Ambrosini <marcoambrosini@proton.me> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
710d4a2
to
fc36367
Compare
For what is worth, I also think it's better to always show the shared label at all times. I think it's the 2nd most important thing after the file name. Let's figure out a better strategy to make things clear soon! |
The presence of the text "Sharing label" in all shared files caused the view to be too loaded, so it's been decided to show it only when the current user is the owner of the share.
Summary
TODO
Checklist