Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Shared" label takes a lot of space in Files list #41620

Closed
jancborchardt opened this issue Nov 20, 2023 · 3 comments · Fixed by #41656
Closed

"Shared" label takes a lot of space in Files list #41620

jancborchardt opened this issue Nov 20, 2023 · 3 comments · Fixed by #41656
Assignees
Labels
1. to develop Accepted and waiting to be taken care of 28-feedback design Design, UI, UX, etc. feature: sharing ❄️ 2023-Winter
Milestone

Comments

@jancborchardt
Copy link
Member

There are some drawbacks to the recent change for the "Shared" label that came with the Vue rewrite:

  • The "Shared" label takes a lot of space in the files list and makes it look very busy
  • Now a lot of entries have the "Shared" label, making it actually more difficult to distinguish your "own" files and files of others at a glance
  • Somehow the avatars got smaller

Now we shouldn’t remove the "Shared" label altogether since it is an important indicator of state and it has also been there in prior versions.

Here are 2 other options we could go for:

  1. Medium with avatars + icons For internal shares coming from others, we use the proposal by @Clementine46 from Sharing icon not displayed for files shared to the user #38156
  2. Remove label for shares from others: This is basically back to how it was before, but keeping the layout and color improvement of the "Shared" label.
Current Medium with avatars + icons Remove label for shares from others
Sharing current sharing medium Sharing plain

cc @nextcloud/designers and @karlitschek since you reported the original issue.

@jancborchardt jancborchardt added design Design, UI, UX, etc. feature: sharing 0. Needs triage Pending check for reproducibility or if it fits our roadmap 28-feedback labels Nov 20, 2023
@jancborchardt jancborchardt moved this to 📐 Design phase in 🖍 Design team Nov 20, 2023
@karlitschek
Copy link
Member

both options would work for me.

@jancborchardt
Copy link
Member Author

We discussed it with @nextcloud/designers and will go with the middle option as that is a good middle ground between the 2, and it takes into account Clémentine’s feedback from user testing.

@jancborchardt jancborchardt added 1. to develop Accepted and waiting to be taken care of and removed 0. Needs triage Pending check for reproducibility or if it fits our roadmap labels Nov 21, 2023
@jancborchardt jancborchardt moved this from 📐 Design phase to 🏗️ At engineering in 🖍 Design team Nov 21, 2023
@marcoambrosini
Copy link
Member

@nextcloud/designers it's impossible for me to implement option 2 without heavily hacking @skjnldsv brand-new super clean code.
Option 3 can be done with minimal changes, so let's go with that for now and have separate owner and sharing column in a next iteration as we talked about in the call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of 28-feedback design Design, UI, UX, etc. feature: sharing ❄️ 2023-Winter
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants