Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add source mount provider to the oc_mounts table #30978

Merged
merged 1 commit into from
Feb 23, 2022

Conversation

icewind1991
Copy link
Member

@icewind1991 icewind1991 commented Feb 2, 2022

Doesn't do anything useful on it's own for now.

But allows being more efficient when setting up the filesystem in the future by only setting up the mounts from a specific provider.

@icewind1991 icewind1991 added the 2. developing Work in progress label Feb 2, 2022
@icewind1991 icewind1991 added this to the Nextcloud 24 milestone Feb 2, 2022
@icewind1991 icewind1991 force-pushed the mount-cache-mount-provider branch 5 times, most recently from 22d0a74 to b68628e Compare February 3, 2022 15:45
@icewind1991 icewind1991 force-pushed the mount-cache-mount-provider branch 5 times, most recently from 1066953 to b3b0a40 Compare February 11, 2022 13:53
@icewind1991 icewind1991 changed the title 🚧 store mountprovider for each mount in the mounts table 🚧 🚧 more fine grained filesystem setup 🚧 Feb 11, 2022
@icewind1991
Copy link
Member Author

icewind1991 commented Feb 11, 2022

changed this PR from just the oc_mounts extension to also have the fs setup work that will make use of it.

Might create a separate PR for parts for easier review

@icewind1991 icewind1991 force-pushed the mount-cache-mount-provider branch 10 times, most recently from b91e77c to 2d4d085 Compare February 18, 2022 13:22
@icewind1991
Copy link
Member Author

icewind1991 commented Feb 18, 2022

Moved the larger work over to a new PR, keeping this as a more easy to review freestanding change.

@icewind1991 icewind1991 changed the title 🚧 more fine grained filesystem setup 🚧 Add source mount provider to the oc_mounts table Feb 18, 2022
@icewind1991 icewind1991 mentioned this pull request Feb 18, 2022
8 tasks
@icewind1991 icewind1991 force-pushed the mount-cache-mount-provider branch from e579b16 to baf28bf Compare February 22, 2022 17:01
@icewind1991 icewind1991 added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Feb 22, 2022
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

core/Migrations/Version240000Date20220202150027.php Outdated Show resolved Hide resolved
@icewind1991 icewind1991 added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Feb 23, 2022
this enabled more fine grained filesystem setup

Signed-off-by: Robin Appelman <robin@icewind.nl>
@icewind1991 icewind1991 force-pushed the mount-cache-mount-provider branch from baf28bf to cfb7923 Compare February 23, 2022 17:03
@icewind1991 icewind1991 merged commit 451f705 into master Feb 23, 2022
@icewind1991 icewind1991 deleted the mount-cache-mount-provider branch February 23, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants