-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fine grained filesystem setup #31265
Conversation
f6106b3
to
a924e07
Compare
e6bd6c5
to
1842956
Compare
e6c59b2
to
190fa2f
Compare
92e8fa3
to
22daf38
Compare
781a13b
to
3c57be1
Compare
Ok, I think this is done for review/testing Particular attention should be given to situations that change what mounts are available for a user (adding/removing shares/external storages/etc) and making sure file listings reflect these changes |
Signed-off-by: Robin Appelman <robin@icewind.nl>
26c2704
to
b065ea3
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
d6f200b
to
77f16f0
Compare
77f16f0
to
e818ac1
Compare
Co-authored-by: Louis <6653109+artonge@users.noreply.github.com> Co-authored-by: Côme Chilliet <91878298+come-nc@users.noreply.github.com> Signed-off-by: Robin Appelman <robin@icewind.nl>
e818ac1
to
881e107
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
@icewind1991 phpcs unhappy, can you fix ? |
also s3 tests don't pass |
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
Signed-off-by: Vincent Petry <vincent@nextcloud.com>
all necessary tests passed successfully in previous builds and my recent changes are not related to those the last commit was to satisfy "checkers" and that one passes now merging... |
Instead of always setting up the entire filesystem, it tries to only setup the bits needed for the path being accessed.
this is done by looking at the cached mounts in the
oc_mounts
table to find the one matching for the path (and optionally also any mounts in subfolders), getting the mountpoints from these mounts and only setting up the mounts from those providers.Various systems are in place to try and ensure that this doesn't lead to an outdated setup if the mounts accessible to the user has changed