-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move root mount setup to mountproviders #31266
Conversation
c0732ab
to
17e2bdd
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
17e2bdd
to
8b7c844
Compare
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
4738a20
to
b0ce876
Compare
…torage Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
Signed-off-by: Robin Appelman <robin@icewind.nl>
…g part files Signed-off-by: Robin Appelman <robin@icewind.nl>
a4387f7
to
ec15020
Compare
Added ci setup with objectstore (multibucket) as root storage and fixed some failures when running with objectstore |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍 and tests are happy
@@ -0,0 +1,70 @@ | |||
name: S3 primary storage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hurrah for more tests!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this backportable separately?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks fine 👍
It does seem to also contain changes that perhaps could be extracted to separate PRs to make them backportable if they solve bigger issues ?
// the entire operation will be safe | ||
|
||
try { | ||
$this->acquireLock(ILockingProvider::LOCK_EXCLUSIVE); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this directly related to this PR or is this a fix that we could use separately ?
@@ -0,0 +1,70 @@ | |||
name: S3 primary storage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this backportable separately?
I'll look into backporting the primary storage ci+fixes |
thanks! |
Removes special casing for the root storage from the filesystem setup logic
Requires:
Part of #31265