feat(files_trashbin): Refactor expire background job to support parallel run

[artonge]

• Follow-up of feat: Limit ExpireTrash job to 30 minutes #51600

The original PR introduced the possibility to continue an ExpireTrash job by saving the offset. This was to prevent having to start over the whole user list when the job crashed or was killed.

But on big instances, one process is not enough to go through all the users in a timely manner. Supporting parallel run allows covering more ground faster.

This PR introduced this possibility. We are now storing the offset right away to allow another parallel job to pick up the task at that point. We are arbitrarily cutting the user list in chunk of 10 to not drastically overflow the 30 minutes time limit.

[come-nc]

apps/files_trashbin/lib/BackgroundJob/ExpireTrash.php:49:4: AssignmentToVoid: Cannot assign $offset to type void (see https://psalm.dev/121)
Sounds real

[sgyuris]

1. The 1. job starts, query for 10 user and write down the offset, let's say: 10
2. The 2. job starts and query for 10 user with offset of 10. Immediately it writes down the offset: 20
3. The 1. job terminates just after it started to clean up user3's trashbin.

What will happen with the remaining files in the user3's trashbin?
What will happen with the user4 - user10 trashbins?

[artonge]

3. The 1. job terminates just after it started to clean up user3's trashbin.

How would that happen ?

[sgyuris]

3. The 1. job terminates just after it started to clean up user3's trashbin.

How would that happen ?

MySQL has gone away... or db deadlock... storage issues or it is killed by any other means like oomkiller...

I know this indicates some kind of infrastructure error still we need to account for it.

[artonge]

MySQL has gone away... or db deadlock... storage issues or it is killed by any other means like oomkiller...

All of those should be caught by the try/catch.

Worth case, like the job being killed, less than 10 users would be skipped, and they will be handled by the next round of jobs.

[sgyuris]

Lets see...

[artonge]

/backport to stable32

[artonge]

/backport to stable31

[artonge]

/backport to stable30

[backportbot]

The backport to stable31 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable31
git pull origin stable31

# Create the new backport branch
git checkout -b backport/52825/stable31

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 1d91e40f 9b5d1184

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/52825/stable31

Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/52825/stable31."} - https://docs.github.com/rest/pulls/pulls#create-a-pull-request

---

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

[backportbot]

The backport to stable30 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable30
git pull origin stable30

# Create the new backport branch
git checkout -b backport/52825/stable30

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 1d91e40f 9b5d1184

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/52825/stable30

Error: Failed to create pull request: Validation Failed: {"resource":"PullRequest","code":"custom","message":"A pull request already exists for nextcloud:backport/52825/stable30."} - https://docs.github.com/rest/pulls/pulls#create-a-pull-request

---

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.