feat(config): Add common audio and video MIME type aliases

[Ratatou2]

Fixes : #30173, Related : #54462

Summary

This pull request updates resources/config/mimetypealiases.dist.json to include common audio and
video MIME type aliases, improving their recognition for features like automated tagging.

Scope of this PR

This change is strictly limited to updating the mimetypealiases.dist.json configuration file.

Any corresponding UI changes, such as updating the MIME type dropdown in the "Automated Tagging"
interface, are considered out of scope for this PR and must be addressed in a separate pull request.

How to test

1. Verify the contents of resources/config/mimetypealiases.dist.json to confirm that the new audio and video MIME types have been added.
2. (Optional) Create an automated tagging rule for a new MIME type (e.g., audio/mpeg). Upload a file of that type (e.g., an MP3 file) and verify that the tag is applied correctly.

[CarlSchwan]

Looks good but I'm a bit unfamiliar with that code

[provokateurin]

@Ratatou2 please rebase onto the master branch. We don't merge the master branch into feature branches.

[Ratatou2]

@Ratatou2 please rebase onto the master branch. We don't merge the master branch into feature branches.

@provokateurin
Done!
Rebased onto the latest master branch.
Thanks for the review!

[Ratatou2]

@Ratatou2 please rebase onto the master branch. We don't merge the master branch into feature branches.

@provokateurin
There's an IntegrityCheck test failure related to the MIME types I added:

The test testVerifyCoreSignatureWithModifiedMimetypelistSignatureData is failing because the expected signature doesn't include the new audio/video MIME types I added.

Could you guide me on how to update the integrity signatures for the new MIME types?
Or is this something that needs to be handled by a maintainer?

Thanks!

[Ratatou2]

Hi @provokateurin @CarlSchwan,

I see there's an IntegrityCheck test failure due to the signature mismatch with the new MIME types I added.
Since auto-merge is enabled but blocked by this test, and new PRs keep getting merged (requiring frequent rebases), could you help guide me on the next steps?

Should I wait for maintainer assistance with the integrity signatures, or is there something I can do to resolve this?

Thanks for your help!

[provokateurin]

You don't need to rebase unless there is a conflict. I'll ask for the signature to be updated.

[provokateurin]

@Ratatou2 please follow the instructions at

server/tests/lib/IntegrityCheck/CheckerTest.php

Line 734 in b7c1594

// When updating the mimetype list the test assets need to be updated as well

[Ratatou2]

@provokateurin

Hello! I've addressed the feedback regarding the test assets you requested.

I followed the instructions in the comment on line 734 of the server/tests/lib/IntegrityCheck/CheckerTest.php file.
I updated the signature.json file to reflect the new MIME type aliases and to ensure the integrity check passes.
The CheckerTest.php file has been restored to its original state.
(I also confirmed that mimetypelist.js is included in .gitignore, so it has not been added to the commit.)

Please let me know if any further modifications are needed.
Thank you for your review 😊

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

[provokateurin]

You'll also need to update the failing test.

[AndyScherzinger]

I guess it needs further changes, like dea865d

But I am not an expert, just checked former commits updating the mapping file

[Ratatou2]

I guess it needs further changes, like dea865d

But I am not an expert, just checked former commits updating the mapping file

Thank you for your feedback.
I'll keep it in mind and check the test errors together.

[Ratatou2]

@provokateurin
I've updated the relevant tests and files accordingly!
(I understand the Cypress and Performance tests are expected to fail for PRs from forks)

This should be ready for a final review and merge :)

[welcome]

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

[injae-kim]

Nice work @Ratatou2 🎉 🎉 🎉