-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
Feat/54462 add mime types automated tagging dropdown #55294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/54462 add mime types automated tagging dropdown #55294
Conversation
…ging dropdown menu - Add Dropdown Menu for common audio MIME types (audio/mpeg, audio/wav, audio/ogg, etc.) - Add Dropdown Menu for common video MIME types (video/mp4, video/webm, etc.) - Improves user experience when creating automated tagging rules for media files Fixes #54462 Signed-off-by: JinHakChoi <ws423257@gmail.com>
This PR includes the updated build artifacts (dist/workflowengine-workflowengine.js and .js.map) because CI detected modifications and failed without them. Fixes #54462 Signed-off-by: JinHakChoi <ws423257@gmail.com>
CarlSchwan
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me
|
@Ratatou2 And merged! Many thanks for your contribution 😃 |
|
@CarlSchwan @blizzz |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Fixes: #54462, Related: #30173
Summary
This PR updates
apps/workflowengine/src/components/Checks/FileMimeType.vue.The update enables batch application of MIME types added in PR #54447 through the Automated Tagging dropdown menu.
Without this feature, although various Audio and Video types have been added to MIME types, users still need to add them manually.
Scope of this PR
This feature simply adds 2 dropdown options to "Automated Tagging" (Audio and Video types).
How to test
(This targets only files that are already included in the existing MIME types in resources/config/mimetypealiases.dist.json)
Screenshots
[UI] Before & After
[Code] Before & After
Test
1) Add Tag for Audio & Video

2) Before add files

3) File upload and automated tagging working correctly
