-
-
Notifications
You must be signed in to change notification settings - Fork 4.7k
feat(workflowengine): Add audio and video MIME types to Automated Tagging dropdown #55116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(workflowengine): Add audio and video MIME types to Automated Tagging dropdown #55116
Conversation
|
@susnux
It seems that these files are causing the issue. I would like to ask for clarification:
Thank you for your guidance. |
|
Hi @nfebe @sorbaugh @blizzz @juliusknorr I committed the following two modified files, but the CI/CD reported a conflict.
Here is what I noticed:
Could you kindly provide guidance on what the proper next step would be? Thank you in advance for your help! 🙏 |
|
Hi @Ratatou2 yeah unfortunately we do commit the dist folder for the server repo. But you don't have to push those we have a build bot that builds on PR. |
|
/compile |
|
/compile / |
|
Ah, /command cannot be run on forks. @Ratatou2 can you build the assets: and commit the dist changes? Maybe do a rebase first. Alternatively we can add you to the org so you can push to a branch on this org. |
…ging dropdown menu - Add Dropdown Menu for common audio MIME types (audio/mpeg, audio/wav, audio/ogg, etc.) - Add Dropdown Menu for common video MIME types (video/mp4, video/webm, etc.) - Improves user experience when creating automated tagging rules for media files Fixes nextcloud#54462 Signed-off-by: JinHakChoi <ws423257@gmail.com>
This PR includes the updated build artifacts (dist/workflowengine-workflowengine.js and .js.map) because CI detected modifications and failed without them. Fixes nextcloud#54462 Signed-off-by: JinHakChoi <ws423257@gmail.com>
6879461 to
7ad2d55
Compare
Previously, only two dist files were committed. This commit updates the full dist directory after running a clean build, since the CI detected additional modifications and failed without them. Fixes nextcloud#54462 Signed-off-by: JinHakChoi <ws423257@gmail.com>
I'm done! |
|
The other checks also do not run on forks. I invited you to this org, then you can push here into a feature branch; alternatively we could push it to a temporary branch just for CI. |
Thank you very much for the invitation to the org 🙏 |
|
Sorry for the late reply. |
|
Superseded by #55294 |
|
Hello there, We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process. Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6 Thank you for contributing to Nextcloud and we hope to hear from you soon! (If you believe you should not receive this message, you can add yourself to the blocklist.) |
Fixes: #54462, Related: #30173
Summary
This PR updates
apps/workflowengine/src/components/Checks/FileMimeType.vue.The update enables batch application of MIME types added in PR #54447 through the Automated Tagging dropdown menu.
Without this feature, although various Audio and Video types have been added to MIME types, users still need to add them manually.
Scope of this PR
This feature simply adds 2 dropdown options to "Automated Tagging" (Audio and Video types).
How to test
(This targets only files that are already included in the existing MIME types in resources/config/mimetypealiases.dist.json)
Screenshots
[UI] Before & After
[Code] Before & After
Test
1) Add Tag for Audio & Video

2) Before add files

3) File upload and automated tagging working correctly
