Skip to content

Conversation

@Ratatou2
Copy link
Contributor

Fixes: #54462, Related: #30173

Summary

This PR updates apps/workflowengine/src/components/Checks/FileMimeType.vue.
The update enables batch application of MIME types added in PR #54447 through the Automated Tagging dropdown menu.
Without this feature, although various Audio and Video types have been added to MIME types, users still need to add them manually.

Scope of this PR

This feature simply adds 2 dropdown options to "Automated Tagging" (Audio and Video types).

How to test

  1. Added Audio and Video dropdown types and connected them to existing Audio and Video tags
  2. Confirmed that subsequently uploaded Audio and Video files are automatically tagged
    (This targets only files that are already included in the existing MIME types in resources/config/mimetypealiases.dist.json)

Screenshots

[UI] Before & After

image

[Code] Before & After

image

Test

1) Add Tag for Audio & Video
image

2) Before add files
image

3) File upload and automated tagging working correctly
image

@Ratatou2 Ratatou2 requested a review from a team as a code owner September 14, 2025 09:41
@Ratatou2 Ratatou2 requested review from nfebe, sorbaugh and susnux and removed request for a team September 14, 2025 09:41
@susnux susnux requested review from blizzz and removed request for susnux September 14, 2025 11:15
@susnux susnux added this to the Nextcloud 33 milestone Sep 14, 2025
@susnux susnux requested a review from juliusknorr September 14, 2025 11:17
@Ratatou2
Copy link
Contributor Author

@susnux
hello!! During the CI/CD process, I encountered the following errors:

Run git status
  git status
  git --no-pager diff
  exit 1 # make it red to grab attention
  shell: /usr/bin/bash -e {0}
HEAD detached at pull/55116/merge
Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git restore <file>..." to discard changes in working directory)
	modified:   dist/workflowengine-workflowengine.js
	modified:   dist/workflowengine-workflowengine.js.map

no changes added to commit (use "git add" and/or "git commit -a")
diff --git a/dist/workflowengine-workflowengine.js b/dist/workflowengine-workflowengine.js
index 5415bb6..fc6b9cd 100644
Binary files a/dist/workflowengine-workflowengine.js and b/dist/workflowengine-workflowengine.js differ
diff --git a/dist/workflowengine-workflowengine.js.map b/dist/workflowengine-workflowengine.js.map
index 22dde73..7da3242 100644
Binary files a/dist/workflowengine-workflowengine.js.map and b/dist/workflowengine-workflowengine.js.map differ
Error: Process completed with exit code 1.
  • /dist/workflowengine-workflowengine.js
  • /dist/workflowengine-workflowengine.js.map

It seems that these files are causing the issue. I would like to ask for clarification:

  1. Should I update and commit all files in the dist directory after running the build?
  2. Or is it sufficient to commit only the two files mentioned above for the CI/CD process?

Thank you for your guidance.

@Ratatou2
Copy link
Contributor Author

Hi @nfebe @sorbaugh @blizzz @juliusknorr

I committed the following two modified files, but the CI/CD reported a conflict.
To verify, I cloned the branch as-is and tried running it — the Flow page didn’t load.
After rebuilding (npm run dev), the page worked normally (the dropdown was also added correctly).

dist/workflowengine-workflowengine.js
dist/workflowengine-workflowengine.js.map

Here is what I noticed:

  1. (After rebuild) When I checked with git status, those two files showed no further changes.
  2. This seems to imply that the entire dist directory may need to be updated.
  3. The dist directory is not in .gitignore.
  4. I’m therefore wondering if updating the whole dist directory is the correct approach.

Could you kindly provide guidance on what the proper next step would be?

Thank you in advance for your help! 🙏

@nfebe
Copy link
Contributor

nfebe commented Sep 19, 2025

Hi @Ratatou2 yeah unfortunately we do commit the dist folder for the server repo.

But you don't have to push those we have a build bot that builds on PR.

@nfebe
Copy link
Contributor

nfebe commented Sep 19, 2025

/compile

@blizzz
Copy link
Member

blizzz commented Sep 19, 2025

/compile /

@blizzz
Copy link
Member

blizzz commented Sep 19, 2025

Ah, /command cannot be run on forks. @Ratatou2 can you build the assets:

npm ci && npm run build

and commit the dist changes? Maybe do a rebase first.

Alternatively we can add you to the org so you can push to a branch on this org.

…ging dropdown menu

- Add Dropdown Menu for common audio MIME types (audio/mpeg, audio/wav, audio/ogg, etc.)
- Add Dropdown Menu for common video MIME types (video/mp4, video/webm, etc.)
- Improves user experience when creating automated tagging rules for media files

Fixes nextcloud#54462

Signed-off-by: JinHakChoi <ws423257@gmail.com>
This PR includes the updated build artifacts (dist/workflowengine-workflowengine.js and .js.map) because CI detected modifications and failed without them.

Fixes nextcloud#54462

Signed-off-by: JinHakChoi <ws423257@gmail.com>
@Ratatou2 Ratatou2 force-pushed the feat/54462-Add-MIME-types-Automated-Tagging-dropdown branch from 6879461 to 7ad2d55 Compare September 19, 2025 11:19
Previously, only two dist files were committed.
This commit updates the full dist directory after running a clean build,
since the CI detected additional modifications and failed without them.

Fixes nextcloud#54462

Signed-off-by: JinHakChoi <ws423257@gmail.com>
@Ratatou2
Copy link
Contributor Author

Ah, /command cannot be run on forks. @Ratatou2 can you build the assets:

npm ci && npm run build

and commit the dist changes? Maybe do a rebase first.

Alternatively we can add you to the org so you can push to a branch on this org.

I'm done!
I rebased first and then added the dist directory (but there were only two files changed).
Thank you both for your guidance! 🙏

@blizzz @nfebe

@blizzz
Copy link
Member

blizzz commented Sep 19, 2025

The other checks also do not run on forks. I invited you to this org, then you can push here into a feature branch; alternatively we could push it to a temporary branch just for CI.

@Ratatou2
Copy link
Contributor Author

The other checks also do not run on forks. I invited you to this org, then you can push here into a feature branch; alternatively we could push it to a temporary branch just for CI.

Thank you very much for the invitation to the org 🙏
This will definitely make future contributions and CI runs much smoother.
Once I’m added to the org, I’ll push my feat/... branch here! : )

@Ratatou2
Copy link
Contributor Author

Ratatou2 commented Sep 24, 2025

Hi @blizzz @nfebe,
Thank you again for the guidance and for the org invitation : )
If adding me to the org takes more time, would it be possible for one of you to temporarily push my branch to the org, just so the CI checks can run properly?
I’m happy to follow whichever workflow you prefer. Thanks in advance!

Sorry for the late reply.
Thank you very much for inviting me to the org 🙏
I’ll work on updating it!

@Ratatou2
Copy link
Contributor Author

Superseded by #55294

@Ratatou2 Ratatou2 closed this Sep 25, 2025
@Ratatou2 Ratatou2 deleted the feat/54462-Add-MIME-types-Automated-Tagging-dropdown branch September 27, 2025 06:32
@github-actions
Copy link
Contributor

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add audio and video MIME types to the Automated Tagging dropdown menu

4 participants