runner.aws_batch: Download .snakemake/metadata/ too #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
tsibley
force-pushed
the
trs/aws-batch/download-snakemake-metadata
branch
2 times, most recently
from
131c55a to
1a3ba39
Compare
|
To test this out, install the CLI from the build for this PR: curl -fsSL --proto '=https' https://nextstrain.org/cli/installer/mac | bash -s pr-build/374then submit an AWS Batch build with |
joverlee521
approved these changes
Jun 17, 2024
There was a problem hiding this comment.
Worked as expected! 🎉
I ran the zika/ingest via AWS Batch
nextstrain build \
--image nextstrain/base:branch-trs-upload-snakemake-metadata \
--aws-batch \
ingest
Then generated the Snakemake report locally
nextstrain build ingest --report
And see the expected stats:
tsibley
added a commit
to nextstrain/docker-base
that referenced
this pull request
Jun 17, 2024
Snakemake stores state information per input/output here and uses it to determine if it needs to re-run rules or not. It seems akin to the file mtimes which we already take care to preserve on upload/download. Additionally, the metadata recorded is used in Snakemake's report generation and is generally useful for looking at workflow statistics. Continue to not upload all of .snakemake/ en masse because it can potentially contain files that interfere with local usage and/or are large and unnecessary. Resolves: <nextstrain/cli#373> Related-to: <nextstrain/cli#374>
Snakemake stores state information per input/output here and uses it to determine if it needs to re-run rules or not. It seems akin to the file mtimes which we already take care to preserve on upload/download. Additionally, the metadata recorded is used in Snakemake's report generation and is generally useful for looking at workflow statistics. Continue to not download all of .snakemake/ en masse because it can potentially contain files that interfere with local usage and/or are large and unnecessary. Resolves: <#373> Related-to: <nextstrain/docker-base#220>
tsibley
force-pushed
the
trs/aws-batch/download-snakemake-metadata
branch
from
1a3ba39 to
b14ae65
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Snakemake stores state information per input/output here and uses it to determine if it needs to re-run rules or not. It seems akin to the file mtimes which we already take care to preserve on upload/download. Additionally, the metadata recorded is used in Snakemake's report generation and is generally useful for looking at workflow statistics.
Continue to not download all of .snakemake/ en masse because it can potentially contain files that interfere with local usage and/or are large and unnecessary.
Resolves: #373
Related-to: nextstrain/docker-base#220
Checklist