Make showcase expandable (re-open) #889
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
victorlin
force-pushed
the
victorlin/make-showcase-expandable
branch
from
13e8906
to
6ffd77c
Compare
victorlin
force-pushed
the
victorlin/list-resources-typing
branch
from
f2e4113
to
9d7b112
Compare
victorlin
force-pushed
the
victorlin/make-showcase-expandable
branch
from
6ffd77c
to
117623b
Compare
victorlin
force-pushed
the
victorlin/list-resources-typing
branch
from
9d7b112
to
213995c
Compare
victorlin
force-pushed
the
victorlin/list-resources-typing
branch
from
7b24562
to
adc666a
Compare
victorlin
force-pushed
the
victorlin/make-showcase-expandable
branch
from
117623b
to
0b655ce
Compare
victorlin
force-pushed
the
victorlin/list-resources-typing
branch
2 times, most recently
from
2ad11e7
to
aae874c
Compare
victorlin
force-pushed
the
victorlin/make-showcase-expandable
branch
from
0b655ce
to
29dc6c6
Compare
victorlin
force-pushed
the
victorlin/list-resources-typing
branch
from
aae874c
to
7c750e2
Compare
Previously, the showcase would drop cards as the width decreases. This is presumably to prevent the showcase from taking up too much height. Instead of hiding the unused cards, allow them to be accessed by making the showcase expandable.
This is the default behavior of justify-content so an alternative is to simply remove the line, but better to be explicit. Note: there is a gap on the right side of the cards because the collection of cards can't be centered with this approach. There are workarounds¹ that don't use flexbox, but keeping it like this for now. ¹ <https://stackoverflow.com/q/32802202>
This was only necessary to determine if the container is expandable, which can be determined from the height alone (already used elsewhere).
victorlin
force-pushed
the
victorlin/make-showcase-expandable
branch
from
29dc6c6
to
0dc2c00
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#878 was approved but merged prematurely. See that PR for reviews and other discussion.
Checklist