Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor prefetch #1631

Merged
merged 8 commits into from
May 11, 2022
Merged

Refactor prefetch #1631

merged 8 commits into from
May 11, 2022

Conversation

Midnighter
Copy link
Contributor

@Midnighter Midnighter commented May 8, 2022

Change prefetch such that it can accept an NCBI settings file as input. Test both variants properly.

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!

@Midnighter Midnighter requested a review from drpatelh May 8, 2022 14:36
@Midnighter Midnighter self-assigned this May 8, 2022
@Midnighter
Copy link
Contributor Author

Usual linting problems with shell block and template.

@drpatelh
Copy link
Member

drpatelh commented May 9, 2022

Usual linting problems with shell block and template.

Can you create an issue on tools for this please? We should fix this.

Copy link
Member

@drpatelh drpatelh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful! 🚀

@drpatelh drpatelh merged commit 79bf60f into master May 11, 2022
@Midnighter Midnighter deleted the refactor-prefetch branch May 11, 2022 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants