Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint error when using shell block instead of script #1557

Closed
Midnighter opened this issue May 10, 2022 · 1 comment
Closed

Lint error when using shell block instead of script #1557

Midnighter opened this issue May 10, 2022 · 1 comment
Assignees
@ewels
Labels
bug Something isn't working
Milestone
2.4

Comments

@Midnighter
Copy link
Contributor

Description of the bug

When using a shell block instead of a script block, I get the following lint error:

when: condition has too many lines

which is probably a parsing bug.

Command used and terminal output

nf-core modules lint sratools/prefetch  # On current PR so not state of master.

System information

nf-core, version 2.4.dev0
@Midnighter Midnighter added the bug Something isn't working label May 10, 2022
@Midnighter
Copy link
Contributor Author

See nf-core/modules#1631 and the failing lint action.

@drpatelh drpatelh added this to the 2.4 milestone May 11, 2022
@ewels ewels self-assigned this May 12, 2022
ewels added a commit to ewels/nf-core-tools that referenced this issue May 12, 2022
@ewels
Module linting: recognise 'shell' block.
479a71d 
Means that we properly exit out of the 'when' block when 'shell' is used instead of 'script'.

Fixes nf-core#1557
@ewels ewels mentioned this issue May 12, 2022
Merged
4 tasks
@ewels ewels closed this as completed May 12, 2022
@ewels ewels mentioned this issue May 12, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ewels ewels

Labels
bug Something isn't working
Projects
None yet
Milestone
2.4
Development

No branches or pull requests
3 participants
@Midnighter @ewels @drpatelh