Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Module linting: recognise shell block. #1569

Merged
merged 1 commit into from
May 12, 2022
Merged

Module linting: recognise shell block. #1569

merged 1 commit into from
May 12, 2022

Conversation

ewels
Copy link
Member

@ewels ewels commented May 12, 2022

Means that we properly exit out of the when block when shell is used instead of script.

Fixes #1557

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@ewels
Module linting: recognise 'shell' block.
479a71d 
Means that we properly exit out of the 'when' block when 'shell' is used instead of 'script'.

Fixes nf-core#1557
@ewels ewels marked this pull request as ready for review May 12, 2022 13:03
@codecov

This comment was marked as off-topic.

Sign in to view
Midnighter
Midnighter approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@Midnighter Midnighter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ewels ewels merged commit 8f5989d into nf-core:dev May 12, 2022
@ewels ewels deleted the fix-1557 branch May 12, 2022 13:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Midnighter Midnighter Midnighter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ewels @Midnighter