Condense linting workflows to one job#4554
Closed
adamrtalbot wants to merge 4 commits intonf-core:masterfrom
Closed
Condense linting workflows to one job#4554adamrtalbot wants to merge 4 commits intonf-core:masterfrom
adamrtalbot wants to merge 4 commits intonf-core:masterfrom
Conversation
Contributor
|
Why don't we run these linting steps as part of pre-commit? |
edmundmiller
added a commit
that referenced
this pull request
Sep 24, 2024
edmundmiller
added a commit
that referenced
this pull request
Sep 24, 2024
edmundmiller
added a commit
that referenced
this pull request
Sep 30, 2024
edmundmiller
added a commit
that referenced
this pull request
Sep 30, 2024
edmundmiller
added a commit
that referenced
this pull request
Nov 18, 2024
* ci: Attempt to split everything out Don't hate me Adam * ci: Add changed since, sharding, and ci * ci: Add filter to try to get jobs split up * ci: Switch to only-changed * ci: See if follow-dependencies works without "related-tests" * ci: Remove skipped tests Idk what we're going to do about these... * ci: Actually use the nf-test version * ci: module => process * ci: Clean up job names * dummy: Make a change * ci: Skip test.tap * ci: Add fetch-depth * ci: Clean up name * ci: Lint everything * ci: Get the job names clean * ci: Add hide-progress on linting * ci: Add psuedocode for conda-fail.yml https://nfcore.slack.com/archives/CJRH30T6V/p1724406283145319 * test: Snapshot the versions contents, not the hash #6505 * ci: Keep running nf-core lint the way it was Blocked by nf-core/tools#3140 * ci: Move conda skips out * ci: Address a comment * style: Move prettier and editorconfig to pre-commit #4554 (comment) * ci: Add note about nf-core lint pre-commit * chore: Copy over conda skips a004c86 2da71b7 * ci: only-changed => changed-since * Add confirm-pass * ci: dynamically set shards * ci: Run 3 process jobs per CI run as an example * install nf-test * fix install nf-test * fix install nf-test * ci: Remove dynamic number of shards, and combine process and workflow filters * ci: Remove variable Nextflow versions * test: Update bowtie versions * ci: Fix indention * ci: We're not testing multiple python versions * style: Clean up job names * build: Remove invisible characters? * test(bowtie): Bump snapshots * style: Remove stray comment * ci: Add GPU tests in their own workflows These will only get trigger on the paths listed * ci(gpu): Clean up triggers and make a note about how to make the includes smarter * ci: pip install cryptography * ci: Try removing path * ci: Add fetch-depth and remove duplicate checkout * test: Remove the second gpu profile * ci: Add path back in * ci(gpu): Remove changed-since * ci: Fix missed dorny/paths-filter update Co-authored-by: mashehu <mashehu@users.noreply.github.com> * Add changes from codereview Co-authored-by: mashehu <mashehu@users.noreply.github.com> * style: Remove example TODO comments https://github.com/nf-core/modules/pull/6286/files#r1846856369 Co-authored-by: mashehu <mashehu@users.noreply.github.com> * refactor: Try tags for GPU CI askimed/nf-test#272 * style: Set NFT_WORKDIR as an ENV variable * style: Run lsp format on a parabricks module For science * test: Add gpu tags to parabricks * ci: Split tags out of matrix * Revert "style: Run lsp format on a parabricks module" This reverts commit d134e78. * ci: Fix name --------- Co-authored-by: Edmund Miller <emiller@jodie.attlocal.net> Co-authored-by: maxulysse <max.u.garcia@gmail.com> Co-authored-by: mashehu <mashehu@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Will require a change on the branch protection.