Expect input of prefixes to KrakenUniq #6912
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Midnighter
force-pushed
the
feat-krakenuniq-prefix
branch
from
ab5735a to
1b4ce5e
Compare
jfy133
approved these changes
Nov 5, 2024
| - prefixes: | ||
| type: string | ||
| description: > | ||
| List of sample identifiers or filename prefixes. Must correspond in order and |
There was a problem hiding this comment.
Maybe give a suggestio how to fix the order (maybe with .sort? Although I can imagine in some very rare cases someone might be weird and not name things such as pairs properly)
There was a problem hiding this comment.
I think that in the normal case, prefixes will be constructed from samples as they come out of a channel and thus they will be in the same order. I do not want to suggest something here that potentially makes the use more complicated than necessary and potentially leads to user errors.
I am in favor of creating a batching function and having that properly tested, but I don't know where we would provide that from?
|
Adding comments is a good idea. |
Midnighter
force-pushed
the
feat-krakenuniq-prefix
branch
from
1b4ce5e to
c1d7d7a
Compare
Breaking Change: Require a new input. Place sequences in sub-directory to prevent trying to compress them later.
Midnighter
force-pushed
the
feat-krakenuniq-prefix
branch
from
c1d7d7a to
6ef7b39
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updating the module will address the following bug in the taxprofiler pipeline nf-core/taxprofiler#533 but requires that the pipeline be refactored to supply the new input.