-
Notifications
You must be signed in to change notification settings - Fork 735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove compressed
flag from all mmseqs modules
#7211
Open
jasmezz
wants to merge
3
commits into
nf-core:master
Choose a base branch
from
jasmezz:fix-mmseqs-compressed
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxulysse
previously approved these changes
Dec 12, 2024
vagkaratzas
previously approved these changes
Dec 12, 2024
Seems like some of the snapshots need to be updated for the tests to pass :) |
Ugh, 3 of these modules are still in pytest. Are you able to port them to nf-test? |
and? |
tsv2exprofiledb |
This was referenced Dec 17, 2024
I tried with 2/3 modules and ran into a couple of problems but maybe that can be a starting point for the porting :) |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've been struggling a long time with mmseqs modules which wouldn't run with the GTDB database (in the nf-core/funcscan pipeline in our case). The reproducible error occurred always late in the "prefilter" step of the mmseqs runs with infos like
aggregatetaxweights died
.@Darcy220606 recently solved the mystery:
Hence, we ran all modules with the
--compressed 1
removed and now they run through successfully even with the big GTDB database.Taking this as confirmation, the flag is removed in all mmseqs modules in this PR. The flag can then be re-added as a parameter on pipeline level if needed.
PR checklist
Closes #XXX
versions.yml
file.label
nf-core modules test <MODULE> --profile docker
nf-core modules test <MODULE> --profile singularity
nf-core modules test <MODULE> --profile conda
nf-core subworkflows test <SUBWORKFLOW> --profile docker
nf-core subworkflows test <SUBWORKFLOW> --profile singularity
nf-core subworkflows test <SUBWORKFLOW> --profile conda