Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

try porting mmseqs/search to nf-test #7231

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

famosab
Copy link
Contributor

@famosab famosab commented Dec 17, 2024

PR checklist

Closes #XXX
Related to #7211

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the module conventions in the contribution docs
  • If necessary, include test data in your PR.
  • Remove all TODO statements.
  • Emit the versions.yml file.
  • Follow the naming conventions.
  • Follow the parameters requirements.
  • Follow the input/output options guidelines.
  • Add a resource label
  • Use BioConda and BioContainers if possible to fulfil software requirements.
  • Ensure that the test works with either Docker / Singularity. Conda CI tests can be quite flaky:
    • For modules:
      • nf-core modules test <MODULE> --profile docker
      • nf-core modules test <MODULE> --profile singularity
      • nf-core modules test <MODULE> --profile conda
    • For subworkflows:
      • nf-core subworkflows test <SUBWORKFLOW> --profile docker
      • nf-core subworkflows test <SUBWORKFLOW> --profile singularity
      • nf-core subworkflows test <SUBWORKFLOW> --profile conda

I tried porting but I always run into the following error:

│                                                                                                                                                                                                                                                                                                                                                                        │
│   Assertion failed:                                                                                                                                                                                                                                                                                                                                                    │
│                                                                                                                                                                                                                                                                                                                                                                        │
│   2 of 2 assertions failed                                                                                                                                                                                                                                                                                                                                             │
│                                                                                                                                                                                                                                                                                                                                                                        │
│   Nextflow stdout:                                                                                                                                                                                                                                                                                                                                                     │
│                                                                                                                                                                                                                                                                                                                                                                        │
│   ERROR ~ Script compilation error                                                                                                                                                                                                                                                                                                                                     │
│   - file : /Users/famke/02-nf-core/modules/.nf-test-1f5468570864d0273649d793a99b787b.nf                                                                                                                                                                                                                                                                                │
│   - cause: The LHS of an assignment should be a variable or a field accessing expression @ line 56, column 22.                                                                                                                                                                                                                                                         │
│                      input[0] = MMSEQS_CREATEDB_QUERY.out.db,                                                                                                                                                                                                                                                                                                          │
│                           ^                                                                                                                                                                                                                                                                                                                                            │
│                                                                                                                                                                                                                                                                                                                                                                        │
│   1 error                                                                                                                                                                                                                                                                                                                                                              │
│                                                                                                                                                                                                                                                                                                                                                                        │
│                                                                                                                                                                                                                                                                                                                                                                        │
│    -- Check '/Users/famke/02-nf-core/modules/.nf-test/tests/1f5468570864d0273649d793a99b787b/meta/nextflow.log' file for details                                                                                                                                                                                                                                       │
│   Nextflow stderr:  

@famosab famosab changed the title try porting to nf-test try porting mmseqs/search to nf-test Dec 17, 2024
@famosab famosab requested a review from a team as a code owner December 17, 2024 07:18
Copy link
Contributor

@prototaxites prototaxites left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully this will make the tests run!

modules/nf-core/mmseqs/search/tests/main.nf.test Outdated Show resolved Hide resolved
modules/nf-core/mmseqs/search/tests/main.nf.test Outdated Show resolved Hide resolved
modules/nf-core/mmseqs/search/tests/nextflow.config Outdated Show resolved Hide resolved
famosab and others added 2 commits December 19, 2024 13:45
Co-authored-by: Jim Downie <19718667+prototaxites@users.noreply.github.com>
@famosab
Copy link
Contributor Author

famosab commented Dec 19, 2024

Now I still get:

│   Test [1f546857] 'sarscov2 - test-search' FAILED (6.297s)                                                                                                                                                                                                   │
│                                                                                                                                                                                                                                                              │
│   Assertion failed:                                                                                                                                                                                                                                          │
│                                                                                                                                                                                                                                                              │
│   2 of 2 assertions failed                                                                                                                                                                                                                                   │
│                                                                                                                                                                                                                                                              │
│   Nextflow stdout:                                                                                                                                                                                                                                           │
│                                                                                                                                                                                                                                                              │
│   ERROR ~ Error executing process > 'MMSEQS_CREATEDB_QUERY (test_query)'                                                                                                                                                                                     │
│                                                                                                                                                                                                                                                              │
│   Caused by:                                                                                                                                                                                                                                                 │
│     Process `MMSEQS_CREATEDB_QUERY (test_query)` terminated with an error exit status (132)                                                                                                                                                                  │
│                                                                                                                                                                                                                                                              │
│                                                                                                                                                                                                                                                              │
│   Command executed:                                                                                                                                                                                                                                          │
│                                                                                                                                                                                                                                                              │
│     if [ "false" == "true" ]; then                                                                                                                                                                                                                           │
│         gzip -c -d contigs.fasta > contigs.fasta                                                                                                                                                                                                             │
│     fi                                                                                                                                                                                                                                                       │
│                                                                                                                                                                                                                                                              │
│     mkdir -p test_query                                                                                                                                                                                                                                      │
│                                                                                                                                                                                                                                                              │
│     mmseqs \                                                                                                                                                                                                                                                 │
│         createdb \                                                                                                                                                                                                                                           │
│         contigs.fasta \                                                                                                                                                                                                                                      │
│         test_query/test_query \                                                                                                                                                                                                                              │
│          \                                                                                                                                                                                                                                                   │
│         --compressed 1                                                                                                                                                                                                                                       │
│                                                                                                                                                                                                                                                              │
│     cat <<-END_VERSIONS > versions.yml                                                                                                                                                                                                                       │
│     "MMSEQS_CREATEDB_QUERY":                                                                                                                                                                                                                                 │
│         mmseqs: $(mmseqs | grep 'Version' | sed 's/MMseqs2 Version: //')
│     END_VERSIONS                                                                                                                                                                                                                                             │
│                                                                                                                                                                                                                                                              │
│   Command exit status:                                                                                                                                                                                                                                       │
│     132                                                                                                                                                                                                                                                      │
│                                                                                                                                                                                                                                                              │
│   Command output:                                                                                                                                                                                                                                            │
│     (empty)                                                                                                                                                                                                                                                  │
│                                                                                                                                                                                                                                                              │
│   Command error:                                                                                                                                                                                                                                             │
│     .command.sh: line 13:    35 Illegal instruction     mmseqs createdb contigs.fasta test_query/test_query --compressed 1                                                                                                                                   │
│                                                                                                                                                                                                                                                              │
│   Work dir:                                                                                                                                                                                                                                                  │
│     /Users/famke/02-nf-core/modules/.nf-test/tests/1f5468570864d0273649d793a99b787b/work/cc/491340106cd3202f039939bdafd8fa                                                                                                                                   │
│                                                                                                                                                                                                                                                              │
│   Container:                                                                                                                                                                                                                                                 │
│     quay.io/biocontainers/mmseqs2:16.747c6--pl5321h6a68c12_0                                                                                                                                                                                                 │
│                                                                                                                                                                                                                                                              │
│   Tip: you can try to figure out what's wrong by changing to the process work dir and showing the script file named `.command.sh`
│                                                                                                                                                                                                                                                              │
│    -- Check '/Users/famke/02-nf-core/modules/.nf-test/tests/1f5468570864d0273649d793a99b787b/meta/nextflow.log' file for details                                                                                                                             │
│   Nextflow stderr:            

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants