Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a sentieon specific subworkflow for DSL2 #405

Open
2 of 6 tasks
maxulysse opened this issue Jul 15, 2021 · 13 comments
Open
2 of 6 tasks

Create a sentieon specific subworkflow for DSL2 #405

maxulysse opened this issue Jul 15, 2021 · 13 comments
Assignees
Labels

Comments

@maxulysse
Copy link
Member

maxulysse commented Jul 15, 2021

EDIT (from @cjfields):
Modules checklist:

  • alignment (accelerated bwa)
  • BQSR (optional?) (EDIT: Won't be implemented. It should be possible to use GATK-based BQSR.)
  • DNAseq (SNV/Indel) - including GVCF support
  • DNAscope (SV and SNV/Indel) - including GVCF support
  • TNseq (tumor/normal) - including GVCF support
  • TNscope (tumor/normal)
@cjfields
Copy link

cjfields commented Apr 12, 2022

Checklist (some are already in place)

Modules

  • alignment (accelerated bwa)
  • BQSR (optional?)
  • DNAseq (SNV/Indel) - including GVCF support
  • DNAscope (SV and SNV/Indel)
  • TNseq (tumor/normal) - including GVCF support
  • TNscope (tumor/normal)

@FriederikeHanssen
Copy link
Contributor

BQSR would be done also with a Sentieon subtool or GATK?

@maxulysse
Copy link
Member Author

Sentieon has that if I remember well

@cjfields
Copy link

Sentieon has that if I remember well

Correct; it also supports VQSR though I'm not sure if that's on the roadmap here, I've been running it separately.

@FriederikeHanssen
Copy link
Contributor

carefully toying around with it, is the correct answer I would say.

@nicorap
Copy link

nicorap commented May 11, 2022

we have a few modules ready from the danish national genome center, I'll just a add them and make the missing ones also with a sub workflow.

@FriederikeHanssen FriederikeHanssen added this to the 3.1 milestone Jun 10, 2022
@cjfields
Copy link

cjfields commented Jul 7, 2022

Small note: in the 2.7.2 workflow we found a bug which skips Sentieon DNAscope and DNAseq when using manually recalibrated BAMs, which seems to be due to a difference in how GATK and Sentieon steps are implemented. GATK HaplotypeCaller, Manta, etc) appear to use a recalibrated BAM file with index here.

However, the next line of code indicates Sentieon steps are using the deduped BAM + index + recalibration table, and the related processes require that table. So, when given a recalibrated BAM + index, this effectively skips Sentieon calling altogether. The input channel for those steps also isn't generated when given a table like this.

The reason I point this out: we can add a simple fix for this and test it, but it's worth noting that all others steps apart from Sentieon use an already recalibrated BAM file and the Sentieon BQSR generates this BAM file anyway, so I'm not sure of the benefit of having this oddly unique step just for Sentieon. Maybe something to consider for the DSL2 implementation?

@nicorap
Copy link

nicorap commented Jul 8, 2022

That makes sense, and also explain why I never got to have sentieon running using 2.7.2 from bam. 😐. I think it’s important to be able to skip BQSR, as for production setups the data should always be the same, so it’s not needed.

@asp8200 asp8200 self-assigned this Aug 10, 2022
@maxulysse maxulysse modified the milestones: 3.1, 3.2 Nov 23, 2022
@maxulysse maxulysse modified the milestones: 3.2, 3.3 Jun 22, 2023
@maxulysse maxulysse modified the milestones: 3.3, 3.4, 3.5 Feb 8, 2024
@maxulysse
Copy link
Member Author

@asp8200 I feel we're getting close to finalize this issue

@asp8200
Copy link
Contributor

asp8200 commented Feb 15, 2024

TNseq and TNscope still not implemented :-/

@maxulysse
Copy link
Member Author

yeah I know, but we're getting closer and closer to completion

@cjfields
Copy link

cjfields commented Feb 15, 2024

@maxulysse you are awesome for taking this one, we're about to get this running for some of our projects.

EDIT: just to add, we're not using TNseq/TNscope for this one (it's all germline) but we can certainly try it out.

@maxulysse
Copy link
Member Author

@asp8200 did all the work, he should get the praise.
You should be able to test it, it's in the latest release already

@FriederikeHanssen FriederikeHanssen removed this from the 3.5 milestone Aug 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants