Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fail linting if empty md5 files found in modules test.yml #1376

Closed
drpatelh opened this issue Dec 17, 2021 · 0 comments · Fixed by #1442
Closed

Fail linting if empty md5 files found in modules test.yml #1376

drpatelh opened this issue Dec 17, 2021 · 0 comments · Fixed by #1442
Assignees
@ewels
Labels
bug Something isn't working linting modules Related to tools for working with DSL2 modules
Milestone
2.3

Comments

@drpatelh
Copy link
Member

Description of the bug

The initial functionality for this was added in #1358

However, it would be nice if the md5 sums aren't automatically removed from test.yml and instead have a hard fail during the linting. This will make it more visibile to contributors that they have empty files and if appropriate they can decide to remove them manually from test.yml

Command used and terminal output

No response

System information

No response
@drpatelh drpatelh added the bug Something isn't working label Dec 17, 2021
@drpatelh drpatelh added this to the 2.2.1 milestone Dec 17, 2021
@drpatelh drpatelh added modules Related to tools for working with DSL2 modules linting labels Dec 17, 2021
@ewels ewels self-assigned this Dec 18, 2021
ewels added a commit to ewels/nf-core-tools that referenced this issue Mar 14, 2022
@ewels
Tweak handling of empty files when generating the test YAML
8e3f636 
Fixes nf-core#1376
@ewels ewels mentioned this issue Mar 14, 2022
Merged
4 tasks
@ewels ewels linked a pull request Mar 14, 2022 that will close this issue
Tweak handling of empty files when generating the test YAML #1442
Merged
4 tasks
@ewels ewels closed this as completed Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ewels ewels

Labels
bug Something isn't working linting modules Related to tools for working with DSL2 modules
Projects
None yet
Milestone
2.3
Development

Successfully merging a pull request may close this issue.

Tweak handling of empty files when generating the test YAML ewels/nf-core-tools
2 participants
@ewels @drpatelh