Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tweak handling of empty files when generating the test YAML #1442

Merged
merged 1 commit into from
Mar 14, 2022

Conversation

ewels
Copy link
Member

@ewels ewels commented Mar 14, 2022

  • Error instead of warning for md5s of empty files
  • Don't skip adding the md5 to the test YAML if an empty file is found

⚠️ UNTESTED ⚠️ - would be fab if someone else could give this a spin and check that it works as intended 🙏🏻

Fixes #1376

PR checklist

  • This comment contains a description of changes (with reason)
  • CHANGELOG.md is updated
  • If you've fixed a bug or added code that should be tested, add tests!
  • Documentation in docs is updated

@codecov
Copy link

codecov bot commented Mar 14, 2022

Codecov Report

Merging #1442 (8e3f636) into dev (bde4731) will not change coverage.
The diff coverage is 40.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev    #1442   +/-   ##
=======================================
  Coverage   65.67%   65.67%           
=======================================
  Files          50       50           
  Lines        5844     5844           
=======================================
  Hits         3838     3838           
  Misses       2006     2006           
Impacted Files Coverage Δ
nf_core/modules/lint/module_tests.py 71.42% <0.00%> (ø)
nf_core/modules/test_yml_builder.py 49.29% <66.66%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bde4731...8e3f636. Read the comment docs.

@ewels ewels linked an issue Mar 14, 2022 that may be closed by this pull request
Copy link
Member

@JoseEspinosa JoseEspinosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I give it a try and works like a charm 🚀

@ewels ewels merged commit ae06289 into nf-core:dev Mar 14, 2022
@ewels ewels deleted the modules-test-empty-md5-tweak branch March 14, 2022 14:48
@ewels
Copy link
Member Author

ewels commented Mar 14, 2022

Awesome, thanks @JoseEspinosa ! Always a bit of a relief when you write code blind 😅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail linting if empty md5 files found in modules test.yml
2 participants