Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make GHA CI MyPy smarter in descerning when it should perform type checking #2480

Open
kedhammar opened this issue Oct 17, 2023 · 1 comment
Open

Make GHA CI MyPy smarter in descerning when it should perform type checking #2480

kedhammar opened this issue Oct 17, 2023 · 1 comment
Assignees
@kedhammar
Labels
enhancement

Comments

@kedhammar
Copy link
Contributor

Description of feature

Currently static type checking is performed on all modified files, but implementing type checking is a work in progress.

Possible solutions:

  • Put headers in the files we want to typecheck / ignore
  • Keep a list of files to typecheck / ignore

We should also add MyPy and its additional type dependencies in requirements-dev.txt
@kedhammar kedhammar self-assigned this Oct 17, 2023
@kedhammar
Copy link
Contributor Author

Adding the updated dev-requirements to a PR #2214 in progress

@mashehu mashehu mentioned this issue Oct 23, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kedhammar kedhammar

Labels
enhancement
Projects
No open projects
Hackathon: November 2023
Status: To do
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kedhammar