Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/python typing/list.py #2214

Merged
merged 15 commits into from
Oct 18, 2023

Conversation

NovakApis
Copy link
Contributor

@NovakApis NovakApis commented Mar 28, 2023

PR checklist

  • This comment contains a description of changes (with reason)
    Added non-redundant types to the list.py file

@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Merging #2214 (9608ce9) into dev (efe344a) will decrease coverage by 0.01%.
Report is 3 commits behind head on dev.
The diff coverage is 100.00%.

❗ Current head 9608ce9 differs from pull request most recent head c699bb5. Consider uploading reports for the commit c699bb5 to get more accurate results

@@            Coverage Diff             @@
##              dev    #2214      +/-   ##
==========================================
- Coverage   70.56%   70.55%   -0.01%     
==========================================
  Files          87       87              
  Lines        9471     9425      -46     
==========================================
- Hits         6683     6650      -33     
+ Misses       2788     2775      -13     
Files Coverage Δ
nf_core/components/list.py 68.83% <100.00%> (ø)

... and 9 files with indirect coverage changes

nf_core/components/list.py Outdated Show resolved Hide resolved
NovakApis and others added 2 commits March 28, 2023 13:59
suggestion accepted - added types for __init__ function arguments

Co-authored-by: Matthias Hörtenhuber <mashehu@users.noreply.github.com>
@kedhammar kedhammar requested a review from mashehu October 18, 2023 09:32
@kedhammar
Copy link
Contributor

Merging this together with #2218 will close issue #2200

@kedhammar kedhammar mentioned this pull request Oct 18, 2023
1 task
@kedhammar kedhammar merged commit 3f3486b into nf-core:dev Oct 18, 2023
6 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants