Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python-typing/modules_utils.py #2218

Merged

Conversation

NovakApis
Copy link
Contributor

PR checklist

  • This comment contains a description of changes (with reason)
    Added types for modules_utils.py

@NovakApis NovakApis changed the title local pytest python-typing/modules_utils.py Mar 28, 2023
@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Merging #2218 (bf1ba30) into dev (efe344a) will increase coverage by 1.40%.
Report is 3 commits behind head on dev.
The diff coverage is 100.00%.

❗ Current head bf1ba30 differs from pull request most recent head b824076. Consider uploading reports for the commit b824076 to get more accurate results

@@            Coverage Diff             @@
##              dev    #2218      +/-   ##
==========================================
+ Coverage   70.56%   71.96%   +1.40%     
==========================================
  Files          87       77      -10     
  Lines        9471     8364    -1107     
==========================================
- Hits         6683     6019     -664     
+ Misses       2788     2345     -443     
Files Coverage Δ
nf_core/modules/modules_utils.py 74.41% <100.00%> (+0.60%) ⬆️

... and 48 files with indirect coverage changes

@NovakApis NovakApis requested a review from mashehu March 28, 2023 13:56
Copy link
Member

@mirpedrol mirpedrol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :) I would wait to merge #2223 first & add mypy linting.

nf_core/modules/modules_utils.py Outdated Show resolved Hide resolved
@kedhammar kedhammar mentioned this pull request Oct 16, 2023
@kedhammar kedhammar mentioned this pull request Oct 18, 2023
1 task
@kedhammar
Copy link
Contributor

Merging this together with #2214 will close issue #2200

@kedhammar kedhammar merged commit 3fddb70 into nf-core:dev Oct 18, 2023
6 of 18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants